Skip to content

test: assert imported users and rooms in import e2e tests #41792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voidmatcha wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

test: assert imported users and rooms in import e2e tests #41792

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9214775
test: assert imported users and rooms in import e2e tests
voidmatcha Aug 15, 2026
80614ad
test: align import assertions with page objects
voidmatcha Aug 15, 2026
cab99e9
test: use semantic room count locators
voidmatcha Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 25 additions & 12 deletions apps/meteor/tests/e2e/imports.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as path from 'path';
import { parse } from 'csv-parse';

import { Users } from './fixtures/userStates';
import { AdminImports, AdminRooms } from './page-objects';
import { AdminImports, AdminRooms, AdminUsers } from './page-objects';
import { test, expect } from './utils/test';

test.use({ storageState: Users.admin.state });
Expand Down Expand Up @@ -46,7 +46,9 @@ const usersCsvsToJson = async (): Promise<void> => {
.pipe(parse({ delimiter: ',' }))
.on('data', (rows) => {
rowUserName.push(rows[0]);
csvImportedUsernames.push(rows[0]);
if (rows[0] !== 'billy.billy') {
csvImportedUsernames.push(rows[0]);
}
})
.on('end', resolve),
);
Expand Down Expand Up @@ -125,13 +127,21 @@ test.describe.serial('imports', () => {
});

test('expect all imported users to be actually listed as users', async ({ page }) => {
const poAdmin = new AdminUsers(page);
await page.goto('/admin/users');

for await (const user of rowUserName) {
const searchResponse = page.waitForResponse((response) => {
const url = new URL(response.url());
return url.pathname.endsWith('/api/v1/users.listByStatus') && url.searchParams.get('searchTerm') === user && response.ok();
});
await page.getByRole('textbox', { name: 'Search Users' }).fill(user);
await searchResponse;
if (user === 'billy.billy') {
await expect(page.locator(`tbody tr td:first-child >> text="${user}"`)).not.toBeVisible();
await expect(page.getByRole('heading', { name: 'No users' })).toBeVisible();
await expect(poAdmin.getUserRowByUsername(user)).not.toBeVisible();
} else {
expect(page.locator(`tbody tr td:first-child >> text="${user}"`));
await expect(poAdmin.getUserRowByUsername(user)).toBeVisible();
}
}
});
Expand All @@ -143,8 +153,8 @@ test.describe.serial('imports', () => {
for await (const room of importedRooms) {
await poAdmin.inputSearchRooms.fill(room.name);

const expectedMembersCount = room.members.split(';').filter((username) => username !== room.ownerUsername).length + 1;
expect(page.locator(`tbody tr td:nth-child(2) >> text="${expectedMembersCount}"`));
const expectedMembersCount = room.members.split(';').filter((username) => username && username !== room.ownerUsername).length + 1;
await expect(poAdmin.getRoomRow(room.name).getByRole('cell').nth(2)).toHaveText(String(expectedMembersCount));
}
});

Expand All @@ -156,9 +166,11 @@ test.describe.serial('imports', () => {
await poAdmin.inputSearchRooms.fill(room.name);
await poAdmin.getRoomRow(room.name).click();

room.visibility === 'private'
? await expect(poAdmin.editRoom.privateInput).toBeChecked()
: await expect(poAdmin.editRoom.privateInput).not.toBeChecked();
if (room.visibility === 'private') {
await expect(poAdmin.editRoom.privateInput).toBeChecked();
} else {
await expect(poAdmin.editRoom.privateInput).not.toBeChecked();
}
await expect(poAdmin.editRoom.roomOwnerInput).toHaveValue(room.ownerUsername);
}
});
Expand All @@ -169,13 +181,14 @@ test.describe.serial('imports', () => {

for await (const user of csvImportedUsernames) {
await poAdmin.inputSearchRooms.fill(user);
expect(page.locator(`tbody tr td:first-child >> text="${user}"`));
const roomRow = poAdmin.getRoomRow(user);
await expect(roomRow).toBeVisible();

const expectedMembersCount = 2;
expect(page.locator(`tbody tr td:nth-child(2) >> text="${expectedMembersCount}"`));
await expect(roomRow.getByRole('cell').nth(2)).toHaveText(String(expectedMembersCount));
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
Outdated

const expectedMessagesCount = dmMessages.length;
expect(page.locator(`tbody tr td:nth-child(3) >> text="${expectedMessagesCount}"`));
await expect(roomRow.getByRole('cell').nth(3)).toHaveText(String(expectedMessagesCount));
}
});
});