-
Notifications
You must be signed in to change notification settings - Fork 5
Josephmlev add images to readme #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be nice if we could add the 3D components for IC1 and the ext power header, so this really is the completed product. |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like to propose replacing this Pcb screenshot and the Schematic screenshot from KiCAD with a github.io page that hosts the HTML BoM. Admittedly, that's more on me since that isn't a simple PR kind of change, but I think it would be much more helpful (and look much nicer). Thoughts? If you agree, let's go ahead and remove these for now and focus on getting a copy of the html BoM committed. Then I can set up the github.io page using it as a source.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Personally, I would vote for leaving images, but that is prefrence. Happy to go either way. Let me know what if any images, and I will edit the PR. I will addi the HTML BOM and a note about how to find it in the README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go ahead and delete this image since it isn't being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do