Josephmlev add images to readme#4
Conversation
Add section for screenshots
It could be worth it to add a version with the pico attached, I was able to follow this for adding a pico 3d render to kicad |
|
Added! Thanks |
dihm
left a comment
dihm
left a comment
There was a problem hiding this comment.
Thank you for putting this long-overdue PR together! I have a few comments/changes requested.
There was a problem hiding this comment.
Let's go ahead and delete this image since it isn't being used.
There was a problem hiding this comment.
It would be nice if we could add the 3D components for IC1 and the ext power header, so this really is the completed product.
There was a problem hiding this comment.
I'd like to propose replacing this Pcb screenshot and the Schematic screenshot from KiCAD with a github.io page that hosts the HTML BoM. Admittedly, that's more on me since that isn't a simple PR kind of change, but I think it would be much more helpful (and look much nicer). Thoughts?
If you agree, let's go ahead and remove these for now and focus on getting a copy of the html BoM committed. Then I can set up the github.io page using it as a source.
There was a problem hiding this comment.
Personally, I would vote for leaving images, but that is prefrence. Happy to go either way. Let me know what if any images, and I will edit the PR. I will addi the HTML BOM and a note about how to find it in the README.
3 participants
I have added a 3D render to the readme as requested in issue 3. I also screenshots of the schematic and PCB layout.