[Artifact 1555] シフトチェンジの作成 - #2069
Open
ogachu0331 wants to merge 10 commits into
Open
Conversation
…SB/Asset into dev/ogachu_artifact1555
Lapis-LJA
requested changes
Jun 16, 2026
Comment on lines
+9
to
+10
| #declare tag 177.changed | ||
| #declare tag 177.change_marker |
Contributor
There was a problem hiding this comment.
命名規則は単語の最初の文字を大文字にしてアンダーバーなしなので、
177.Changed, 177.ChangeMarkerかな
Lapis-LJA
reviewed
Jun 16, 2026
| execute as @e[type=marker,tag=177.change_marker,limit=1] at @s rotated as @a[tag=177.changed,limit=1] run tp @s ~ ~ ~ ~ ~ | ||
|
|
||
| # 対象を自身の場所・向きへtp | ||
| execute at @s rotated as @s run tp @a[tag=177.changed,limit=1] ~ ~ ~ ~ ~ |
Contributor
There was a problem hiding this comment.
このat @.s rotated as @.sって要る？
Contributor
Author
There was a problem hiding this comment.
なくても問題なかったので消しました。
あと、動作確認はセレクターをアマスタに置き換えてやっていたんですが、やっぱり実際のプレイヤーと行うほうがいいですか?
Lapis-LJA
reviewed
Jul 16, 2026
Comment on lines
+16
to
+17
| data modify storage asset:artifact Name set value '[{"text":"シフト","color":"#0E82E8","bold":true},{"text":"チェンジ","color":"#C9A410"}]' | ||
| data modify storage asset:artifact Lore set value ['{"text":"サーバー内のランダムな味方1名と位置を入れ替える","color":"white"}'] |
Contributor
There was a problem hiding this comment.
なんか本来Loreの1行上にあったコメントが消えてる？
ちょっと気になった
Lapis-LJA
requested changes
Jul 16, 2026
|
|
||
| # 他にアイテム等確認する場合はここに書く | ||
| # 自身がワープ可能か | ||
| execute if entity @s[tag=CanUsed] if entity @s[predicate=lib:is_ban_tp_area] run tellraw @s {"text":"不思議な力が転送を妨害した。","color":"dark_aqua"} |
Contributor
There was a problem hiding this comment.
おそらくソウルメイトから持ってきたんだろうけど、使用不可メッセージとして使うならcolorはredのほうが良いかも？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
使用するとサーバー内のランダムな味方と位置を入れ替えます