Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3213 +/- ##
==========================================
- Coverage 95.63% 95.63% -0.01%
==========================================
Files 177 177
Lines 20949 20994 +45
Branches 2112 2118 +6
==========================================
+ Hits 20035 20077 +42
- Misses 725 728 +3
Partials 189 189 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
maliasadi
commented
Sep 15, 2026
| the base op's id (`2C(S){}{wires:1}{}`), not the wrapper's own arguments. The number of controls | ||
| an operator instance carries now reaches the rule closure from lowering, so `<n>C(...)` rules are | ||
| synthesized at trace time rather than only on demand. | ||
|
|
Member
Author
There was a problem hiding this comment.
I'll merge this when addressing other suggestions
Suggested change
| The id a distributed rule declares for each gate it produces is now *generated* with its | |
| modifiers, through the same `build_graph_op_id` builder the rest of the frontend uses, instead of | |
| being spliced into a finished id string. The modifiers are placed canonically by construction, so | |
| a resource that is already symbolic composes (`Adjoint(C(X))` spells `C(Adjoint(X))`) rather than | |
| being rejected as out of order. | |
| A rule may also *produce* a multi-controlled gate. The control count a resource carries is now | |
| kept when the closure explores it through its base, so the `<n>C(...)` node that resource names | |
| gets rules of its own instead of only `C(...)`; an operator reached again under more controls | |
| pays just for the variants it is still missing. The name paired with such an id is spelled the | |
| way PennyLane's registry spells it, since a multi-controlled id reads `<n>C(...)` and PennyLane | |
| names every controlled operator `C(...)` whatever its control count. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
A follow-up PR to #3204; adding support for the symbolic rules PL registers for
C(Op)here.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-130374]