Open
Conversation
github-actions
bot
added
area:front
Synar
force-pushed
the
ali/fix-margins-editoast-new-table-front
branch
from
75be82f to
3beb10f
Compare
Contributor
Author
|
Fixed the tests (they were only broken by the second commit), and reworked one of them in order to test our behavior of checking margins only from one path steps with an arrrival time to the next, skipping other path steps (this new test would have caught the bug fixed in the first commit). |
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Synar
force-pushed
the
ali/fix-margins-editoast-new-table-front
branch
from
3beb10f to
d69dc03
Compare
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Synar
force-pushed
the
ali/fix-margins-editoast-new-table-front
branch
from
d69dc03 to
a612a45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #16152