editoast, front: fix margin at end instead of start of interval

Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>

Author: Synar

editoast/src/views/timetable/simulation.rs

@@ -180,7 +180,7 @@ pub fn path_item_respect_margins<T: TrainScheduleLike>(
                 path_item_time_provisional - prev_path_item_time_provisional;
             let margin_diff = interval_duration_final - interval_duration_provisional;
 
-            res[path_item_index] = margin_diff >= -TIME_APPROX_ERROR.num_milliseconds();
+            res[prev_path_item_index] = margin_diff >= -TIME_APPROX_ERROR.num_milliseconds();
         });
 
     res
@@ -727,18 +727,20 @@ mod tests {
     }
 
     fn shallow_sim_too_fast_on_interval() -> SimulationResponseSuccess {
+        // Too fast from A to B and from D to E
+        // Respects margins from A to C as B to C compensates A to B, too fast on C to E as not compensated
         SimulationResponseSuccess {
             base: ReportTrain {
-                path_item_times: vec![0, 4_730_243, 13_828_795],
+                path_item_times: vec![0, 100_000, 200_000, 300_000, 400_000],
                 ..Default::default()
             },
             provisional: ReportTrain {
-                path_item_times: vec![0, 5_222_392, 15_267_584],
+                path_item_times: vec![0, 100_000, 200_000, 300_000, 400_000],
                 ..Default::default()
             },
             final_output: CompleteReportTrain {
                 report_train: ReportTrain {
-                    path_item_times: vec![0, 5_280_030, 15_300_915],
+                    path_item_times: vec![0, 95_000, 201_000, 301_000, 396_000],
                     ..Default::default()
                 },
                 ..Default::default()
@@ -801,7 +803,7 @@ mod tests {
             &sim.provisional.path_item_times,
             &schedule,
         );
-        assert_eq!(*respect, [true, false, true]);
+        assert_eq!(*respect, [false, true, true]);
     }
 
     #[test]
@@ -813,7 +815,7 @@ mod tests {
             &sim.provisional.path_item_times,
             &schedule,
         );
-        assert_eq!(*respect, [true, true, false]);
+        assert_eq!(*respect, [true, true, false, true, true]);
     }
 
     #[test]

editoast/src/views/timetable/tests/train_schedule_too_fast_on_interval.json

@@ -37,24 +37,50 @@
                     "type": "uic"
                 }
             }
+        },
+        {
+            "id": "idD",
+            "location": {
+                "operational_point": {
+                    "uic": 87700003,
+                    "secondary_code": "BV",
+                    "type": "uic"
+                }
+            }
+        },
+        {
+            "id": "idE",
+            "location": {
+                "operational_point": {
+                    "uic": 87700004,
+                    "secondary_code": "BV",
+                    "type": "uic"
+                }
+            }
         }
     ],
     "schedule": [
         {
             "at": "idB",
-            "arrival": "PT5280S",
-            "stop_for": null,
+            "arrival": null,
+            "stop_for": "PT1S",
             "reception_signal": "OPEN"
         },
         {
             "at": "idC",
-            "arrival": "PT15300S",
+            "arrival": "PT201S",
+            "stop_for": null,
+            "reception_signal": "OPEN"
+        },
+        {
+            "at": "idE",
+            "arrival": "PT396S",
             "stop_for": "P0D",
             "reception_signal": "OPEN"
         }
     ],
     "margins": {
-        "boundaries": ["idC"],
+        "boundaries": ["idE"],
         "values": [
             "6.5min/100km",
             "0%"

front/src/modules/timesStops/hooks/useTimesStopsTableData.ts

@@ -273,11 +273,7 @@ const useTimesStopsTableData = (
               })
             : undefined;
         const scheduleNotHonored = stableIsValid && !stablePathItemRespect?.times[stepIndex];
-        // The back end returns the status at the end of the interval but we want to display the information at the beginning of the interval so we check the next path items status
-        const marginNotHonored =
-          stableIsValid &&
-          stepIndex < selectedTrain.path.length - 1 &&
-          !stablePathItemRespect?.margins[stepIndex + 1];
+        const marginNotHonored = stableIsValid && !stablePathItemRespect?.margins[stepIndex];
         const margins = computeMargins(
           getTheoreticalMargins(selectedTrain),
           selectedTrain,