Skip to content

fix: Skip extra header columns in iostat parsing #4676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
InoMurko wants to merge 4 commits into
base: master
Choose a base branch
from
+97 −10
Open

fix: Skip extra header columns in iostat parsing #4676

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be655fb
fix: Skip extra header columns in iostat parsing
InoMurko Apr 27, 2026
3385679
Apply suggestions from code review
InoMurko May 8, 2026
002e6a8
pr suggestion
InoMurko May 8, 2026
c45da41
changelog and format of test inputs
InoMurko May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions util/iostat/iostat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ func Run(ctx context.Context, interval int, receiver chan DeviceStats) {
stat := DeviceStats{}
var err error
for i, field := range fields {
if i >= len(data) {
Comment thread
bragaigor marked this conversation as resolved.
// Some iostat builds emit a header with more columns than a data row
// (e.g. trailing header tokens without values). Skip the rest of the header.
Comment thread
InoMurko marked this conversation as resolved.
Outdated
break
}
Comment thread
bragaigor marked this conversation as resolved.
switch field {
case "Device", "Device:":
stat.DeviceName = data[i]
Expand Down
Loading