fix: Skip extra header columns in iostat parsing#4676
Conversation
Handle cases where header has extra columns in iostat.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4676 +/- ##
===========================================
- Coverage 52.38% 34.37% -18.02%
===========================================
Files 506 506
Lines 73739 60420 -13319
===========================================
- Hits 38630 20767 -17863
- Misses 29951 35950 +5999
+ Partials 5158 3703 -1455 |
Co-authored-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
bragaigor
left a comment
There was a problem hiding this comment.
It's looking great! Just a nitpick whitespace suggestion and you're missing a changelog file. You can base that off this one:
nitro/changelog/bragaigor-nit-4678.md
Lines 1 to 2 in 6dce8d1
where the bullet point becomes Skip extra header columns in iostat parsing
Thanks @bragaigor. Didn't notice the bad indentation at all! Also, added the changelog file - I don't have a issue ticket so I kept it short in the filename. Hope that's ok. |
bragaigor
left a comment
There was a problem hiding this comment.
Thanks for the fix and for iterating on the comments, much appreciated. The PR looks great from my side.
Quick heads-up: We recently changed our internal process around merging PRs, so this may take a bit longer than usual to land. Please bear with us, and thanks again for the contribution!
Skip parsing when a stats row has fewer fields than the last Device header row.
It breaks when i >= len(data), i.e. when this data row has fewer whitespace-separated fields than the header has columns (or than we’ve consumed so far).