Skip to content

[Adhoc] Fix bigquery data characterization flow run #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandantck merged 5 commits into from
Sep 1, 2026
Merged

[Adhoc] Fix bigquery data characterization flow run #3162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
261f4ea
add D2E_BIGQUERY_JDBC_URL env to docker compose
brandantck Aug 19, 2026
5f61d8e
enable session for bigquery jdbc connection
brandantck Aug 19, 2026
fc6b9df
update test
brandantck Aug 19, 2026
57bc69c
Merge branch 'develop' into brandantck/ADHOC-fix-bigquery-datacharact…
brandantck Aug 26, 2026
70d5916
Merge branch 'develop' into brandantck/ADHOC-fix-bigquery-datacharact…
brandantck Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,7 @@ services:
TASK_API_ENFORCE_HTTPS: ${TASK_API_ENFORCE_HTTPS:-true}
LOW_NUMBER_SUPPRESSION_THRESHOLD: ${LOW_NUMBER_SUPPRESSION_THRESHOLD:-10}
ROUNDING_TARGET: ${ROUNDING_TARGET:-10}
D2E_BIGQUERY_JDBC_URL: ${D2E_BIGQUERY_JDBC_URL:-}

# Needed only for future alterations of schema when version upgrades
# alp-logto-db-post-alterations-init:
Expand Down
3 changes: 2 additions & 1 deletion plugins/flows/_shared_flow_utils/dao/daobase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ def build_bigquery_r_connection_string(
"jdbc:bigquery://https://www.googleapis.com/bigquery/v2:443;"
f"ProjectId={project};OAuthType=0;"
f"OAuthServiceAcctEmail={client_email};"
f"OAuthPvtKeyPath={key_path}"
f"OAuthPvtKeyPath={key_path};"
"EnableSession=1"
Comment thread
brandantck marked this conversation as resolved.
)
return (
"connectionDetails <- DatabaseConnector::createConnectionDetails("
Expand Down
3 changes: 2 additions & 1 deletion plugins/flows/_shared_flow_utils/tests/test_r_connection_string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def test_bigquery_r_connection_string_shape():
"connectionString = 'jdbc:bigquery://https://www.googleapis.com/bigquery/v2:443;"
"ProjectId=my-gcp-project;OAuthType=0;"
"OAuthServiceAcctEmail=svc@my-gcp-project.iam.gserviceaccount.com;"
"OAuthPvtKeyPath=/tmp/google-sa.json'" in result
"OAuthPvtKeyPath=/tmp/google-sa.json;"
"EnableSession=1'" in result
)
assert "user = ''" in result and "password = ''" in result
Loading