[Adhoc] Fix bigquery data characterization flow run - #3162
Merged
brandantck merged 5 commits intoSep 1, 2026
Conversation
brandantck
requested review from
SantanM,
Zhimin-arya,
alicia-koh,
csafreen,
p-hoffmann and
suwarnoong
as code owners
August 19, 2026 09:22
Contributor
There was a problem hiding this comment.
Pull request overview
Adds BigQuery JDBC session support and forwards the driver download URL to the dataflow worker.
Changes:
- Enables BigQuery JDBC sessions for transaction statements.
- Exposes
D2E_BIGQUERY_JDBC_URLto the worker container.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
plugins/flows/_shared_flow_utils/dao/daobase.py |
Enables JDBC sessions in BigQuery connections. |
docker-compose.yml |
Passes the BigQuery JDBC URL to the worker. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Zhimin-arya
approved these changes
Aug 19, 2026
mwaiyee
approved these changes
Aug 20, 2026
suwarnoong
approved these changes
Sep 1, 2026
brandantck
deleted the
brandantck/ADHOC-fix-bigquery-datacharacterization
branch
September 1, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dataflow-gen-worker.EnableSession=1to bigquery jdbc connection so that transaction control statements are valid.Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)