Skip to content

[16.0][IMP] shopfloor_reception/mobile: show product image in 'set_lot' - #1210

Open
nicolas-delbovier-acsone wants to merge 3 commits into
OCA:16.0from
acsone:16.0-imp-shopfloor_reception-add-product-image-in-set_lot
Open

[16.0][IMP] shopfloor_reception/mobile: show product image in 'set_lot'#1210
nicolas-delbovier-acsone wants to merge 3 commits into
OCA:16.0from
acsone:16.0-imp-shopfloor_reception-add-product-image-in-set_lot

Conversation

@nicolas-delbovier-acsone

@nicolas-delbovier-acsone nicolas-delbovier-acsone commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

@OCA-git-bot

OCA-git-bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Hi @mmequignon, @JuMiSanAr,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added series:16.0 mod:shopfloor_reception Module shopfloor_reception mod:shopfloor_reception_mobile Module shopfloor_reception_mobile labels Jul 2, 2026
@nicolas-delbovier-acsone nicolas-delbovier-acsone changed the title [16.0][IMP] shopfloor_reception: show product image in 'set_lot' [16.0][IMP] shopfloor_reception/mobile: show product image in 'set_lot' Jul 2, 2026
@nicolas-delbovier-acsone
nicolas-delbovier-acsone force-pushed the 16.0-imp-shopfloor_reception-add-product-image-in-set_lot branch 2 times, most recently from abce2f5 to df5b3de Compare July 3, 2026 08:20
@nicolas-delbovier-acsone nicolas-delbovier-acsone mentioned this pull request Jul 7, 2026
Merged
jbaudoux
jbaudoux requested changes Jul 7, 2026
View reviewed changes
Comment thread shopfloor_reception/actions/data.py Outdated
@nicolas-delbovier-acsone
nicolas-delbovier-acsone force-pushed the 16.0-imp-shopfloor_reception-add-product-image-in-set_lot branch 2 times, most recently from c76af96 to eb1ac6e Compare July 7, 2026 11:46
@nicolas-delbovier-acsone nicolas-delbovier-acsone mentioned this pull request Jul 7, 2026
Open
jbaudoux
jbaudoux reviewed Jul 16, 2026
View reviewed changes

@jbaudoux jbaudoux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's a good idea to always display the image here.
The initial idea was to confirm it's the right product in case you select the line to receive instead of scanning its barcode.
However, now, if the barcode is missing, the product/packaging barcode/dimension screen is shown first to fill the barcode (if you enabled the option).

Ideally, the image should be show first so that the operator can confirm it's the right product. Especially if the operator will start filling product/packaging data. We saw a case where the operator was processing the wrong product. Maybe an intermediate screen to add.

Besides that, regarding this specific PR, maybe it's not bad to always show the image on this set lot step.
WDYT @sebalix @mt-software-de @Highcooley

@jbaudoux jbaudoux added the question Further information is requested label Jul 17, 2026
@nicolas-delbovier-acsone
nicolas-delbovier-acsone force-pushed the 16.0-imp-shopfloor_reception-add-product-image-in-set_lot branch from eb1ac6e to 11e8b31 Compare July 31, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees

No one assigned

Labels

mod:shopfloor_reception_mobile Module shopfloor_reception_mobile mod:shopfloor_reception Module shopfloor_reception question Further information is requested series:16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-delbovier-acsone @OCA-git-bot @jbaudoux