Skip to content

[16.0][IMP] shopfloor_mobile: show product image in product details - #1203

Merged
OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:16.0-imp-shopfloor-product-image-in-product-details
Jul 7, 2026
Merged

[16.0][IMP] shopfloor_mobile: show product image in product details#1203
OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:16.0-imp-shopfloor-product-image-in-product-details

Conversation

@nicolas-delbovier-acsone

@nicolas-delbovier-acsone nicolas-delbovier-acsone commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Split part from: #1200

image

cc @jbaudoux

@OCA-git-bot

OCA-git-bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Hi @simahawk,
some modules you are maintaining are being modified, check this out!

@nicolas-delbovier-acsone nicolas-delbovier-acsone mentioned this pull request Jun 30, 2026
Closed
jbaudoux
jbaudoux reviewed Jun 30, 2026
View reviewed changes

@jbaudoux jbaudoux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fan of having the picture inside the box. I find it renders better after the box like it was done in the cluster picking

Image

Comment thread shopfloor_mobile/static/wms/src/components/detail/detail_product.js Outdated
Comment thread shopfloor_mobile/static/wms/src/components/detail/detail_product.js
max-width="128"
aspect-ratio="1"
contain
class="rounded elevation-1"

@jbaudoux jbaudoux Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why rounded?

@nicolas-delbovier-acsone nicolas-delbovier-acsone Jun 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A purely aesthetic choice

@nicolas-delbovier-acsone
nicolas-delbovier-acsone force-pushed the 16.0-imp-shopfloor-product-image-in-product-details branch from 02f7537 to f3a1484 Compare June 30, 2026 13:19
@nicolas-delbovier-acsone nicolas-delbovier-acsone changed the title [16.0][IMP] shopfloor_mobile: show product imgae in product details [16.0][IMP] shopfloor_mobile: show product image in product details Jul 2, 2026
@jbaudoux

jbaudoux commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1203-by-jbaudoux-bump-minor, awaiting test results.

@nicolas-delbovier-acsone

nicolas-delbovier-acsone commented Jul 7, 2026

Copy link
Copy Markdown
Author

I'm not fan of having the picture inside the box. I find it renders better after the box like it was done in the cluster picking

See #1210 for a picture that is out side the detailed card in the 'set_lot' state

@OCA-git-bot
OCA-git-bot merged commit 080186d into OCA:16.0 Jul 7, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at dd703fe. Thanks a lot for contributing to OCA. ❤️

@nicolas-delbovier-acsone nicolas-delbovier-acsone mentioned this pull request Jul 7, 2026
Open
@lmignon
lmignon deleted the 16.0-imp-shopfloor-product-image-in-product-details branch August 5, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees

No one assigned

Labels

merged 🎉 mod:shopfloor_mobile Module shopfloor_mobile series:16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-delbovier-acsone @OCA-git-bot @jbaudoux