earthly: move to earthbuild 0.8.17#463269
Conversation
|
|
The new docker image: |
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/3013 |
| e17gtk = throw "'e17gtk' has been removed because it was archived upstream."; # Added 2026-01-15 | ||
| e-search = throw "'e-search' has been removed due to outdated KF5 dependencies"; # Added 2026-05-01 | ||
| eagle = throw "'eagle' has been removed because official support ends 2026-06-07. It depended on qt5 webengine, which was removed for its numerous security issues. For more details, see the autodesk announcement at https://www.autodesk.com/support/technical/article/caas/sfdcarticles/sfdcarticles/Autodesk-EAGLE-Announcement-Next-steps-and-FAQ.html"; # Added 2026-04-26 | ||
| earthly = throw "'earthly' has been discontinued. It is replaced by a community fork 'earthbuild'"; # Added 2025-11-19 |
There was a problem hiding this comment.
This should be a warnAlias if we even provide compatible symlinks.
There was a problem hiding this comment.
official project does and lines 49,50 of the package.nix do symlink, so just needs a warnAlias instead of throw, yes;)
92d00fa to
c79b505
Compare
| # when true, just one subPackage is built even though two are listed | ||
| __structuredAttrs = false; |
There was a problem hiding this comment.
does anyone have any idea how to solve this? nixpkgs-vet requires setting this to true, but once I do that, only the first subPackage from the list is built 🤔
There was a problem hiding this comment.
I looked into it, didn't find concrete suggestions of what to do about it unfortunately, don't understand it myself
Related issue: #205690
Check creation: NixOS/nixpkgs-vet#203
Docs mentions:
https://nix.dev/manual/nix/2.31/store/derivation/#structured-attrs
https://nix.dev/manual/nix/2.31/language/advanced-attributes.html#adv-attr-structuredAttrs
Probably the most helpful:
Simillar question from another package: #494879 (comment)
Found there: https://nixos.mayflower.consulting/blog/2020/01/20/structured-attrs/
IDK but related: NixOS/nix#14847
There was a problem hiding this comment.
@Likivik @SuperSandro2000 can you please look here? https://github.com/NixOS/nixpkgs/pull/463269/changes#diff-b838f8df5dbf32422669fcffd06d2b4c57a05c2475dd09216f77d4583028ced0R23
Three options:
- my misunderstanding of the go docs
- go docs are outdated
- a bug in go builder
Any suggestions what do we do? The current version works, but it is a workaround.
|
How goes? |
|
Tried it locally and it installed fine for me on my nixos box. |
|
@SuperSandro2000 could we please have a review? |
Earthly has been discontinued. Community fork is called EarthBuild.
Version bumped to v0.8.17 from v0.8.16.
New binaries are:
earth,earth-debugger. Links toearthlyandearthly-debuggedprovided for compatibility.See this post: https://earthly.dev/blog/shutting-down-earthfiles-cloud/
and this issue: EarthBuild/earthbuild#158
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.