-
Notifications
You must be signed in to change notification settings - Fork 282
Added values only to discovery count. #3530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hoper-38709
wants to merge
16
commits into
integration
Choose a base branch
from
task/add-sum-count-to-discovery
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8111c51
Added values only to discovery count.
hoper-38709 076cbf5
Removed some commented-out code.
hoper-38709 634dfa4
Make the Discover Transformer FIELD to be optional.
hoper-38709 9d7ffd2
DiscoveryTransformer: use blank rather then empty.
hoper-38709 90e9eca
Refactored DiscoveryIterator for terms only.
hoper-38709 31003b7
Added additional unit tests for DiscoveryLogicTest.
hoper-38709 638c7b7
Code review & formatting concerns.
hoper-38709 b19201d
Added TermOnlyEntry.
hoper-38709 15dea54
Edited SetTop
hoper-38709 c89ec04
Refactored DiscoveryIterator for TermsOnly
hoper-38709 0089205
Edited DiscoveryTransformer.
hoper-38709 7d2e165
Added warning suppression for some legacy rawtypes.
hoper-38709 13c8eb6
Edited DiscoveryTransformerTest.
hoper-38709 610c355
Addressed code review comments.
hoper-38709 5c236a3
Addressed code review comments (2).
hoper-38709 53de981
Updated DiscoveryLogic adding UniqueFilter.
hoper-38709 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
...c/main/java/datawave/query/discovery/DiscoveredThingValuesOnlyConditionalTransformer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package datawave.query.discovery; | ||
|
|
||
| import java.util.function.UnaryOperator; | ||
|
|
||
| public class DiscoveredThingValuesOnlyConditionalTransformer implements UnaryOperator<DiscoveredThing> { | ||
|
|
||
| boolean valuesOnly; | ||
|
hoper-38709 marked this conversation as resolved.
Outdated
|
||
|
|
||
| DiscoveredThingValuesOnlyConditionalTransformer(boolean valuesOnly) { | ||
| this.valuesOnly = valuesOnly; | ||
| } | ||
|
|
||
| public DiscoveredThing apply(DiscoveredThing dt) { | ||
| if (valuesOnly) { | ||
| return new DiscoveredThing(dt.getTerm(), dt.getColumnVisibility()); | ||
| } | ||
| return dt; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.