Added values only to discovery count.#3530
Open
hoper-38709 wants to merge 16 commits into
Open
Conversation
foster33
reviewed
Apr 30, 2026
hoper-38709
force-pushed
the
task/add-sum-count-to-discovery
branch
from
0707bd6 to
076cbf5
Compare
avgAGB
reviewed
May 4, 2026
hlgp
reviewed
May 7, 2026
| fields.add(this.makeField("VALUE", markings, "", 0L, thing.getTerm())); | ||
| /** | ||
| * Added query model to alias FIELD | ||
| * Added query model to alias FIELD, if DiscoveredThing::field both not NULL and not empty. |
Collaborator
There was a problem hiding this comment.
apply similar logic to DATE and DATATYPE. We only want to show the term value and the combined vis.
hlgp
reviewed
May 7, 2026
hlgp
reviewed
May 7, 2026
hlgp
reviewed
May 7, 2026
apmoriarty
reviewed
May 7, 2026
apmoriarty
reviewed
May 7, 2026
apmoriarty
reviewed
May 7, 2026
Collaborator
|
New direction: Turns out we don't need to aggregate the vis. We only need to return the first instance of each unique rowid. So, if valuesOnly, break when you get the first valid TermEntry. Each next iteration will have just a single DiscoveredThing. Do the logic to only set the term and vis. In setTop, precedent is already set to modify the column family to advance to the next column family. In the values only case we will want to skip to the next row. Note: appending a null byte to the end of the current row won't work, so recommend the next start key in the skip logic be the row and last possible column family (something like \uffff) |
hlgp
reviewed
May 12, 2026
hlgp
reviewed
May 19, 2026
hlgp
reviewed
May 19, 2026
apmoriarty
reviewed
May 20, 2026
apmoriarty
reviewed
May 20, 2026
apmoriarty
reviewed
May 20, 2026
apmoriarty
reviewed
May 20, 2026
apmoriarty
requested changes
May 20, 2026
hlgp
reviewed
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add values only option to return from a DiscoveryLogic/ DiscoveryIterator.