Skip to content

Test/compare show output dco - #16112

Open
mneha05 wants to merge 5 commits into
NVIDIA:mainfrom
mneha05:test/compare-show-output-dco
Open

mneha05 wants to merge 5 commits into
NVIDIA:mainfrom
mneha05:test/compare-show-output-dco

Conversation

@mneha05

@mneha05 mneha05 commented Sep 26, 2026 •

Copy link
Copy Markdown

Fixes #12675.

Description

This updates the existing ToPrettyString integration coverage so DataFrame.show() output is compared between CPU and GPU execution.

The test now:

  • creates the same date/string projection used by the existing ToPrettyString coverage;
  • orders the input by str_col before rendering so the textual comparison is deterministic;
  • captures df.show() output separately for the CPU and GPU runs;
  • uses the repository-prescribed assert_gpu_and_cpu_are_equal_collect helper to verify CPU/GPU execution and result equality;
  • compares the captured CPU and GPU display output after the prescribed assertion completes.

The earlier custom SHOW assertion helper has been removed, so the shared assertion infrastructure is unchanged and local-sort handling is unaffected.

Validation:

  • isolated capture/comparison regression simulation passed;
  • DCO sign-off check passes;
  • full Spark/GPU integration workflows are pending maintainer approval on this external-contributor PR.

This change is test-only and does not alter runtime code or performance.

AI assistance was used to explore the repository, implement the test changes, and review the diff. I reviewed the final changes before submission.

Checklists

Documentation

  • Updated for new or modified user-facing features or behaviors
  • No user-facing change

Testing

  • Added or modified tests to cover new code paths
  • Covered by existing tests
  • Not required

Performance

  • Tests ran and results are added in the PR description
  • Issue filed with a link in the PR description
  • Not required

Signed-off-by: Neha Mahesh <mahesh54@purdue.edu>
Signed-off-by: Neha Mahesh <mahesh54@purdue.edu>
@greptile-apps

greptile-apps Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Test file refactors output capture for a date casting test.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR updates a date-formatting integration test to compare captured CPU and GPU show() output, use a collect assertion, and order its rows deterministically.

Reviews (2) · Last reviewed commit: "test: align imports with style"

Comment thread integration_tests/src/main/python/cast_test.py Outdated
Comment thread integration_tests/src/main/python/cast_test.py Outdated
Comment thread integration_tests/src/main/python/asserts.py Outdated
Signed-off-by: Neha Mahesh <mahesh54@purdue.edu>
Signed-off-by: Neha Mahesh <mahesh54@purdue.edu>
Signed-off-by: Neha Mahesh <mahesh54@purdue.edu>
@mneha05

mneha05 commented Sep 26, 2026

Copy link
Copy Markdown
Author

test: compare ToPrettyString show output on CPU and GPU

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TEST] Add ToPrettyString test case for Scala case

2 participants