Repository navigation
revert(ci): undo workflow changes bundled with VGR #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| --- | ||
| name: switchyard-pr-preparation | ||
| description: Prepare or update a Switchyard pull request, check its scope, and identify CI changes that require separate user confirmation before editing. | ||
| --- | ||
|
|
||
| # Switchyard PR Preparation | ||
|
|
||
| Read the repository's `AGENTS.md` and inspect the complete diff against the intended PR base, | ||
| including uncommitted and untracked files. Check that each change belongs to the requested scope. | ||
|
|
||
| ## CI changes require separate confirmation | ||
|
|
||
| Before changing CI, show the proposed files, behavior, and reason, then obtain explicit user | ||
| confirmation for those CI changes. General approval to fix code, prepare a PR, or address review | ||
| comments does not authorize CI changes. A confirmation already given for the specific CI change | ||
| remains valid. | ||
|
|
||
| This covers GitHub workflows and actions, commit or PR lint rules, and scripts or configuration | ||
| changes that alter CI checks, triggers, permissions, or required behavior. Do not weaken a check | ||
| or change a repository policy to make an unrelated PR pass. | ||
|
|
||
| Read-only inspection and local reproduction can proceed while confirmation is pending. If the | ||
| existing diff already contains CI changes, identify their origin and show them separately for | ||
| review. Do not silently include or discard them. | ||
|
|
||
| ## Before presenting the PR | ||
|
|
||
| Review the full diff again for CI changes, including files outside `.github/` that CI executes. | ||
| State which CI behavior changes, the specific confirmation received, and how it was validated. | ||
| Keep unrelated CI policy changes in a separate PR and confirm that scope with the user. | ||
|
|
||
| Use the repository's commit and PR title conventions. Follow the existing approval requirements | ||
| for commits, pushes, and posting the PR; this skill grants no publication permission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
git diff --no-ext-diff 4cbb2d11626765dc0ea6ca92c85830dbaa531c8f 8dd4bfa2a5be1c0257f43177dfe0eb2ad5fe5d4c -- .github/workflows/commitlint.yml git show 4cbb2d11626765dc0ea6ca92c85830dbaa531c8f:.github/workflows/commitlint.yml git show 8dd4bfa2a5be1c0257f43177dfe0eb2ad5fe5d4c:.github/workflows/commitlint.yml rg -n 'wagoid/commitlint|pin.*SHA|full commit SHA|allowed actions|NVIDIA|permissions:' .github .agentsRepository: NVIDIA-NeMo/Switchyard
Length of output: 4154
🏁 Script executed:
Repository: NVIDIA-NeMo/Switchyard
Length of output: 19798
🏁 Script executed:
Repository: NVIDIA-NeMo/Switchyard
Length of output: 2141
Handle the mutable action reference in a separate approved CI change.
wagoid/commitlint-github-action@v6is newly introduced relative to the PR base. A moved tag can change the third-party code executed by this workflow. The workflow exposes only read access to repository contents and pull requests, so the reachable impact is limited to the commitlint job and data available through those permissions.This PR restores the pre-#716 workflow exactly. Do not change the reference here. In the separate CI-policy change, replace
@v6with a verified full commit SHA and retain the version in a comment.🤖 Prompt for AI Agents
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
✅ Runtime observed
🏁 Script executed:
rg -n -i 'wagoid/commitlint|action.?policy|allowed.?actions|full commit sha|pin.*sha|commitlint' .github .agents docs git diff --no-ext-diff 4cbb2d11626765dc0ea6ca92c85830dbaa531c8f 8dd4bfa2a5be1c0257f43177dfe0eb2ad5fe5d4c -- .github/workflows/commitlint.ymlRepository: NVIDIA-NeMo/Switchyard
Length of output: 1487
🏁 Script executed:
Repository: NVIDIA-NeMo/Switchyard
Length of output: 7734
🌐 Web query:
NVIDIA GitHub Actions policy allowed actions full commit SHA wagoid commitlint-github-action💡 Result:
🏁 Script executed:
Repository: NVIDIA-NeMo/Switchyard
Length of output: 7110
🌐 Web query:
site:github.com/NVIDIA-NeMo/Switchyard/pull/1015 commitlint action policy💡 Result:
🏁 Script executed:
Repository: NVIDIA-NeMo/Switchyard
Length of output: 4601
🏁 Script executed:
Repository: NVIDIA-NeMo/Switchyard
Length of output: 41452
🏁 Script executed:
Repository: NVIDIA-NeMo/Switchyard
Length of output: 1811
🌐 Web query:
Is wagoid/commitlint-github-action verified in GitHub Marketplace💡 Result:
Use an approved commitlint implementation.
The
pull_requestrun rejectswagoid/commitlint-github-action@v6before any job starts because the NVIDIA Actions policy does not allow it. Pinning the action to a SHA does not change its owner or approval status. Use an approved action, or restore the base workflow’s local Commitlint invocation.Suggested fix
🤖 Prompt for AI Agents