Skip to content

DEV 2469 fix github action - #286

Draft
qqiao2024 wants to merge 16 commits into
developfrom
feat/dev-2469-fix-github-action
Draft

DEV 2469 fix github action#286
qqiao2024 wants to merge 16 commits into
developfrom
feat/dev-2469-fix-github-action

Conversation

@qqiao2024

Copy link
Copy Markdown
Contributor

No description provided.

@qqiao2024
qqiao2024 marked this pull request as ready for review February 6, 2024 21:13

@mpsolano mpsolano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread .github/workflows/ci.yaml
- release/**
- hotfix/**
- feat/dev-583-remove-set-env-in-github-actions
- feat/dev-2469-fix-github-action

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for testing? Do we plan to remove this before merging?

@jiakf jiakf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we should just wait and make sure all the github jobs run and pass before merging

@qqiao2024
qqiao2024 marked this pull request as draft February 7, 2024 15:01
@qqiao2024

Copy link
Copy Markdown
Contributor Author

Converted to draft until we know how to solve this

looks good, we should just wait and make sure all the github jobs run and pass before merging

I don't think that is going to happen. We are using deprecated runners:

* [The Ubuntu 18.04 Actions runner image will begin deprecation on 2022/08/08 and will be fully unsupported by 2023/04/03 actions/runner-images#6002](https://github.com/actions/runner-images/issues/6002)

* [Ubuntu 16.04 environment will be removed on September 20, 2021 actions/runner-images#3287](https://github.com/actions/runner-images/issues/3287)

* [The macOS 10.15 Actions runner image will begin deprecation on 5/31/22 and will be fully unsupported by 12/1/22 for GitHub and ADO actions/runner-images#5583](https://github.com/actions/runner-images/issues/5583)

@jiakf jiakf mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants