DEV 2469 fix github action - #286
Draft
qqiao2024 wants to merge 16 commits into
Draft
Conversation
added 16 commits
February 6, 2024 10:37
qqiao2024
marked this pull request as ready for review
February 6, 2024 21:13
ProfOak
approved these changes
Feb 6, 2024
mpsolano
approved these changes
Feb 6, 2024
| - release/** | ||
| - hotfix/** | ||
| - feat/dev-583-remove-set-env-in-github-actions | ||
| - feat/dev-2469-fix-github-action |
Member
There was a problem hiding this comment.
Is this just for testing? Do we plan to remove this before merging?
jiakf
approved these changes
Feb 7, 2024
jiakf
left a comment
Contributor
There was a problem hiding this comment.
looks good, we should just wait and make sure all the github jobs run and pass before merging
I don't think that is going to happen. We are using deprecated runners:
|
qqiao2024
marked this pull request as draft
February 7, 2024 15:01
Contributor
Author
|
Converted to draft until we know how to solve this
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.