DEV-2479: py38 upgrade - #287
Merged
Merged
Conversation
jiakf
force-pushed
the
feat/DEV-2479-upgrade-py38
branch
from
February 16, 2024 16:14
cb52cb3 to
01f1957
Compare
jiakf
marked this pull request as ready for review
February 19, 2024 16:04
ProfOak
approved these changes
Feb 19, 2024
stilesj-uchicago
previously approved these changes
Feb 19, 2024
jiakf
force-pushed
the
feat/DEV-2479-upgrade-py38
branch
3 times, most recently
from
February 21, 2024 20:52
7c67bac to
4a3ce19
Compare
jiakf
force-pushed
the
feat/DEV-2479-upgrade-py38
branch
from
March 26, 2024 16:58
4a3ce19 to
43fc1e6
Compare
jiakf
force-pushed
the
feat/DEV-2479-upgrade-py38
branch
from
April 1, 2024 01:58
31a54b4 to
43fc1e6
Compare
wrkhenddher
reviewed
Apr 2, 2024
stilesj-uchicago
approved these changes
Apr 3, 2024
|
Any idea when this PR will be merged? Current bioconda recipe is broken and this PR might fix it: |
qqiao2024
approved these changes
Jun 20, 2024
jiakf
force-pushed
the
feat/DEV-2479-upgrade-py38
branch
2 times, most recently
from
June 25, 2024 19:52
5748956 to
d0c7f80
Compare
This updates DTT to run with py38 and drops support for earlier python versions. This change also includes running pyupgrade on the repository and updating the github actions to run on supported operating systems.
jiakf
force-pushed
the
feat/DEV-2479-upgrade-py38
branch
from
June 26, 2024 16:22
d0c7f80 to
a3380f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also includes running pyupgrade for py38 on the repository, so most of the file changes are from that. The main fixes in this PR:
spawnthe default method for multiprocessing as opposed tofork, so the code as written no longer worked for macOS. For now, we are switching DTT to use threads on macOS as opposed to processes, so the same as what is done on Windows. Some performance testing was done to compare the threads vs process versions of macOS DTT, and the performance was comparable.