Conversation
8390b04 to
ec20854
Compare
ec20854 to
b2a94e4
Compare
b2a94e4 to
daced4a
Compare
daced4a to
5ac618e
Compare
5ac618e to
99d8a25
Compare
99d8a25 to
b411532
Compare
f8318c2 to
2d339ae
Compare
|
For (1), blocking folder delete if there's a readonly file within the folder would implicitly mean that you cannot delete a workspace if it has a readonly file within it, which feels unintentional. Additionally, even for the normal folder case, the spec feels too vague. There's four approaches I can take to this:
For (2), it looks like I forgot to push the change to |
2d339ae to
fc545ab
Compare
|
Thanks @Mythicaeda - options 2 and 3 above both seem pretty reasonable. I think option 2 (check ahead of time, don't delete anything if readonly is found) is preferable for a couple reasons - despite being different from how the OS does it, it aligns with our principle of having these ops be as atomic as possible & either completely succeed or fail. It also lines up with the Clipper feedback we've gotten re: wanting as many guardrails as possible to stop them from accidentally deleting a folder they didn't mean to delete. If possible the error message returned in this case should also call out the paths of any read-only files it finds, to help the user track them down if they do intend to delete. |
- Update Move and Copy to consistently use java.nio.Files instead of a mix of java.nio.Files and java.io.File - Update thrown exceptions list for accuracy
- Will no longer include METADATA type files in response - Made RenderType in charge of the Aerie Metadata type for the backend, as that extension is expected to be fairly constant - Remove unneeded Optional wrapper from `listFiles` method
- No longer updates `lastEditedBy` when the metadata is updated (unless that field is missing)
- Move user setup to before tests are run - Move shared User objects to the User helper class - Move APIResponse Body Parser to RequestBodyHelper
…d as readonly - move exceptions into "Exceptions" package
Error Responses were not using the provided Javax serializer on the single item endpoints due to already being converted to JsonObject
Was only running Copy instructions if the user did not have sufficient permissions
Description
.aerieto.meta.seqdevlistContentsendpoint to hideMETADATA-type files by default, and to provide the contents of the metadata files if thewithMetadataflag is providedVerification
I'd like to add some tests that focus on the contents of the metadata files, and how they're reconstructed after deletion, as well as basic bindings tests for the endpoints.
Documentation
No docs are invalidated, but we should add documenting these new endpoints to writing docs for the other workspace server endpoints
Future work