Open
Conversation
…read-only support
…arch improvements - Add CodeMirror-based JSON editor for user metadata in the metadata panel with syntax highlighting, validation, and auto-save on blur/file switch - Add "Open Folder" button in content area and context menu to navigate the file browser to a selected folder - Extend file browser search to match against metadata fields (createdBy, lastEditedBy, version, user metadata) - Move read-only permission handling from editor components to FileMetadataBanner - Add success toast for read-only status changes
… Auto discard changes when changing tabs or files.
Add EditorView.editable configuration alongside EditorState.readOnly in SequenceEditor and WorkspaceMetadataPanel components. Both facets need to be properly configured for CodeMirror to correctly handle editor editability state changes. Changes: - Add EditorView.editable.of() to compartment reconfiguration in both components - Refactor SequenceEditor readonly logic to use isEditable variable for clarity - Reorder onReadOnlyChange prop declaration in SequenceEditor This ensures the editor properly responds to readonly state changes by configuring both the readOnly state facet and the editable view facet.
Extract duplicate click handler logic into a `togglePanel` function to reduce code duplication in WorkspaceRightIconRail component. The function handles toggling between metadata, command, and dictionary panels, closing the active panel if clicked again or switching to a new panel otherwise. This improves maintainability by following the DRY principle and makes the component easier to modify in the future.
…anel - Add explicit type imports (ArgTextDef, TimeTagInfo) from sequence languages - Declare component variables at top for better organization and clarity - Simplify timeTagNode reactive statement formatting - Improve code readability by making variable declarations explicit This refactoring improves code maintainability by organizing variable declarations in a clear, conventional pattern at the component's top level.
This fixes a potential race condition where the workspace UI might not reflect the saved state and ensures proper async/await flow in the save operation.
- Add columnShiftResize prop to BulkActionDataGrid and SingleActionDataGrid components - Create centralized cookie utilities (setCookie, getCookie) with consistent expiration handling - Implement column state persistence in WorkspaceFileBrowser using cookies - Move cookie constants to centralized location (constants/cookies.ts) - Refactor SidebarProvider to use new cookie utilities instead of manual document.cookie - Add comprehensive test coverage for cookie utility functions This change improves code maintainability by consolidating cookie management logic and enables users to persist their column resize preferences across sessions.
- Add `hasReadOnlyNodes` prop to track selection of read-only files - Disable rename and delete operations when read-only files are selected - Display appropriate error messages for read-only restrictions - Visually indicate "Move" is disabled (with reduced opacity) while keeping "Copy" available for read-only files - Update permission checks to consider read-only status alongside existing permissions This prevents users from accidentally modifying or deleting files that should remain read-only, improving data integrity in the workspace.
- Remove custom event dispatcher from WorkspaceLeftIconRail component - Use existing handleTabClick function for actions button instead of custom event - Simplify component interface by removing actionsClick event handler prop - Add "Open Folder" button to workspace document view for easier folder access This refactoring reduces code complexity by consolidating tab click handling into a single method while improving UX with the new folder access feature.
- Move currentBreadcrumbPath export to group with other props in WorkspaceSidebar - Restructure workspace content area component hierarchy - Improve code organization without changing functionality This refactoring improves code readability by grouping related exports together and simplifying the component structure in the workspace page.
- Use type-only imports for Locator and Page to optimize bundle size - Add definite assignment assertions (!:) to Locator properties initialized in constructor - Update action sidebar selector from 'complementary' to 'tablist' role for more accurate element targeting These changes improve TypeScript type safety and ensure more reliable E2E test selectors in the Action fixture.
- Remove unused workspace and user props from ImportWorkspaceFileModal - Remove enableContextMenu prop from WorkspaceTreeView component calls - Add selectionHasReadOnlyNodes prop to MoveItemToWorkspaceModal - Prevent moving read-only files with appropriate error messaging - Update permission checks to account for read-only file selections - Clean up unused type imports and component props This simplifies the component interface by removing unnecessary props that were being passed through multiple layers, and adds protection against moving read-only files to prevent data integrity issues.
duranb
changed the title
**Changes:** - Configure both `EditorState.readOnly` and `EditorView.editable` facets to properly control editor interactivity - Update E2E test selectors to use more specific button roles in tabpanel instead of generic labels - Reorder component props for consistency (move callback to end) **Why:** The text editor was not properly respecting readonly/preview/loading states because only the `readOnly` facet was configured. CodeMirror requires both `readOnly` and `editable` facets to be set for proper behavior. The E2E test updates improve selector reliability by targeting more specific button elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from #1901
___REQUIRES_AERIE_PR___="1807"Corresponding backend branch NASA-AMMOS/plandev#1807. Closes #1767
Summary
TODO:
Test plan