feat: add outliers_percentage_target to reduce_outliers() for target-based outlier reduction [stacks on #2516]#2519
Draft
pidefrem wants to merge 4 commits into
Draft
Conversation
5 tasks
outliers_percentage_target to reduce_outliers() for target-based outlier reductionoutliers_percentage_target to reduce_outliers() for target-based outlier reduction [stacks on #2516]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
feat: add
outliers_percentage_targettoreduce_outliers()for target-based outlier reductionreduce_outliers()requires manually specifying athresholdparameter. Users must run the method repeatedly to find a threshold that achieves their desired outlier rate — a trial-and-error workflow evident in 10+ open issues aboutreduce_outliersbehavior.Changes:
Add an
outliers_percentage_targetparameter (float, 0–1): auto-searches for the threshold that achieves the target outlier percentage using binary search. Works with all 4 existing strategies (probabilities, distributions, c-tf-idf, embeddings) and requires no changes to the underlying reduction logic.Cannot set both
thresholdandoutliers_percentage_target— raisesValueError. Backward compatible: defaults toNone, existing behavior unchanged.Fixes #2501
Before submitting