feat: add outliers_nb_target to approximate_distribution() for target-based min_similarity [stacks on #2519]#2520
Draft
pidefrem wants to merge 5 commits into
Draft
Conversation
outliers_nb_target to approximate_distribution() for target-based min_similarityoutliers_nb_target to approximate_distribution() for target-based min_similarity [stacks on #2519]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
feat: add
outliers_nb_targettoapproximate_distribution()for target-based min_similarityapproximate_distribution()requires manually specifyingmin_similarity. Users must iterate to find a value that produces an acceptable number of documents with zero topic distribution.Changes:
Add an
outliers_nb_targetparameter (int): auto-searches for themin_similarityvalue that achieves the target number of zero-distribution documents using binary search.Performance optimization: Refactors the internals so the expensive similarity matrix is computed once and reused across all binary search iterations:
compute_similarities_for_approximate_distribution()— compute oncecompute_topic_distributions_for_approximate_distribution()— apply threshold, iterateCannot set both
min_similarityandoutliers_nb_target. Backward compatible: defaults toNone.Fixes #2502
Before submitting