Repository navigation
ci(office): quickstart smoke — install, serve, probe /api/state #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Quickstart smoke lacks required changelog entry
The new
quickstartjob changes CI behavior without an entry in the root changelog. The repository's contribution rules require a changelog update for PRs.Learn more
The contribution checklist requires a semver changelog update before opening a PR. This PR adds a new quickstart smoke job, but the root changelog's Unreleased section has no entry for it.
Example: The Unreleased section lists other CI changes, including post-publish smoke tests, but not this install-and-serve check.
Recommended fix: Add an Unreleased entry for the new office quickstart smoke coverage in the root CHANGELOG.md.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — CHANGELOG.md now records the
quickstartjob under Unreleased (scope: both OSes,OFFICE_*/XDG store isolation,/api/stateJSON assertions, trap cleanup).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in e1bc428 — CHANGELOG entry for the quickstart smoke job added under Unreleased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not applicable on this branch.
CHANGELOG.mdalready opens Unreleased with an entry for this job: "CI —test-office.ymlgains aquickstartjob that smoke-tests thepackages/officeREADME quick start end to end onwindows-latest+ubuntu-latest..." (install, serve,/api/stateassertions, store isolation, trap cleanup). The PR checklist item is satisfied; this looks like a stale diff read.