Repository navigation
ci(office): quickstart smoke — install, serve, probe /api/state - #84
Conversation
The documented path (pip install -e . -> devin-office --port 8788 ->
GET /api/state) was never exercised in CI. The new quickstart job runs
it verbatim on windows+ubuntu, pointing every store the daemon resolves
(OFFICE_DATA_DIR/CONF_DIR/STATE_DIR plus HOME/XDG/APPDATA fallbacks) at
runner temp, so it provably never touches a real Devin store. Readiness
is a curl poll with a process-alive check, not a fixed sleep; the state
payload is asserted as JSON with the expected keys and the dashboard
page on / is checked too.
Verified locally: editable install -> entry point -> 200 + JSON
{"ts":..,"agents":[],"error":"sessions.db not found: <tmpdir>"}.
Generated with [Devin](https://devin.ai) & QA Engineer Icaro Galvao
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
github-actions
Bot
added
the
github_actions
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| with: | ||
| package-dir: packages/office | ||
|
|
||
| quickstart: |
There was a problem hiding this comment.
🟡 Quickstart smoke lacks required changelog entry
The new quickstart job changes CI behavior without an entry in the root changelog. The repository's contribution rules require a changelog update for PRs.
Learn more
The contribution checklist requires a semver changelog update before opening a PR. This PR adds a new quickstart smoke job, but the root changelog's Unreleased section has no entry for it.
Example: The Unreleased section lists other CI changes, including post-publish smoke tests, but not this install-and-serve check.
Recommended fix: Add an Unreleased entry for the new office quickstart smoke coverage in the root CHANGELOG.md.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Fixed — CHANGELOG.md now records the quickstart job under Unreleased (scope: both OSes, OFFICE_*/XDG store isolation, /api/state JSON assertions, trap cleanup).
There was a problem hiding this comment.
Fixed in e1bc428 — CHANGELOG entry for the quickstart smoke job added under Unreleased.
There was a problem hiding this comment.
Not applicable on this branch. CHANGELOG.md already opens Unreleased with an entry for this job: "CI — test-office.yml gains a quickstart job that smoke-tests the packages/office README quick start end to end on windows-latest + ubuntu-latest..." (install, serve, /api/state assertions, store isolation, trap cleanup). The PR checklist item is satisfied; this looks like a stale diff read.
Review finding: the new quickstart CI job had no entry in the root changelog's Unreleased section, which the contribution checklist requires. Records the job scope (both OSes, isolated stores, JSON assertions, trap cleanup). Generated with [Devin](https://devin.ai) & QA Engineer Icaro Galvao Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
github-actions
Bot
added
the
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
gate-resolved-via: fallback — 1 blocking thread(s) cleared by replies citing verified fix commits, with the Devin Review status on e1bc428 re-verified clean:
Threads left unresolved — the findings stay visible. |
Summary
quickstartjob intest-office.yml(ubuntu + Windows): runs the README quick start verbatim —pip install -e packages/office,devin-office --port 8788, pollsGET /api/stateuntil ready, thenGET /.OFFICE_*,HOME/USERPROFILE,XDG_*,APPDATA) point at${{ runner.temp }}— the daemon never touches real user stores (verified locally:sessions.db -> /tmp/.../data/cli/sessions.db (exists=False)).loading(the background collect loop ran, not just the socket) and validates the payload shape (agents/services/events/ts).Test plan
ready after 2 poll(s),GET / -> 200 (html ok)pytest packages/office— 61 passedGenerated with Devin