Part 1: Removal of various warnings supression and fixing their warnings, chagning class and delete C++ keywords in names, and changes related to compile common target as C++

.github/workflows/build.yml

@@ -7,7 +7,7 @@ env:
   MYSQL_USER: 'ragnarok'
   MYSQL_PASSWORD: 'ragnarok'
   MYSQL_ALLOW_EMPTY_PASSWORD: 'yes'
-  DEBIAN_COMMON_PACKAGES: make git python3 libzstd-dev python3-venv cmake g++
+  DEBIAN_COMMON_PACKAGES: make git python3 libzstd-dev python3-venv cmake
 
 defaults:
   run:
@@ -20,7 +20,7 @@ jobs:
     strategy:
       matrix:
         # Testing the oldest and newest supported version of gcc/clang on our supported platofrms
-        CC: ["clang", "gcc"]
+        CC: ["clang-21", "gcc-15"]
         RENEWAL: [""]
         CLIENT_TYPE: ["", "-DENABLE_PACKETVER_RE=ON", "-DENABLE_PACKETVER_ZERO=ON"]
         HTTPLIB: ["", "-DWITH_HTTP_PARSER=llhttp"]
@@ -30,6 +30,11 @@ jobs:
         exclude:
           - PACKET_VERSION: "-DPACKETVER=20100105"
             CLIENT_TYPE: "-DENABLE_PACKETVER_ZERO=ON"
+        include:
+          - CXX: 'g++-15'
+            CC: 'gcc-15'
+          - CXX: 'clang++-21'
+            CC: 'clang-21'
 
     # github.head_ref will stop previous runs in the same PR (if in a PR)
     # github.run_id is a fallback when outside a PR (e.g. every merge in master will run, and previous won't stop)
@@ -55,10 +60,11 @@ jobs:
           --health-timeout=2s
           --health-retries=3
     env:
-      INSTALL_PACKAGES: ${{ matrix.CC }} mariadb-client
+      INSTALL_PACKAGES: ${{ matrix.CC }} ${{ matrix.CXX }} mariadb-client
       SQLHOST: mariadb
       CC: ${{ matrix.CC }}
-      CONFIGURE_FLAGS: -DCMAKE_C_COMPILER=${{ matrix.CC }} -DCMAKE_BUILD_TYPE=Debug -DENABLE_WERROR=ON -DENABLE_BUILDBOT=ON ${{ matrix.RENEWAL }} ${{ matrix.HTTPLIB }} ${{ matrix.CLIENT_TYPE }} ${{ matrix.SANITIZER }} ${{ matrix.PACKET_VERSION }} -DENABLE_EPOLL=ON -DBUILD_HPMHOOKING=ON
+      CXX: ${{ matrix.CXX }}
+      CONFIGURE_FLAGS: -DCMAKE_C_COMPILER=${{ matrix.CC }} -DCMAKE_CXX_COMPILER=${{ matrix.CXX }} -DCMAKE_BUILD_TYPE=Debug -DENABLE_WERROR=ON -DENABLE_BUILDBOT=ON ${{ matrix.RENEWAL }} ${{ matrix.HTTPLIB }} ${{ matrix.CLIENT_TYPE }} ${{ matrix.SANITIZER }} ${{ matrix.PACKET_VERSION }} -DENABLE_EPOLL=ON -DBUILD_HPMHOOKING=ON
     steps:
       - uses: actions/checkout@v6
         with:
@@ -68,6 +74,13 @@ jobs:
         run: |
           uname -a
 
+      - uses: actions/cache/restore@v6
+        name: restore conan cache
+        id: cache
+        with:
+          path: ~/.conan2
+          key: ${{ runner.os }}-${{ matrix.CC }}-${{ hashFiles('conanfile.py') }}
+
       - name: install packages
         run: |
           ./tools/ci/retry.sh apt-get update

.github/workflows/controller.yml

@@ -15,6 +15,10 @@ jobs:
     needs: hwsapibot
     if: ${{ !failure() && !cancelled() }}
     uses: ./.github/workflows/tools.yml
+  tools-windows:
+    needs: hwsapibot
+    if: ${{ !failure() && !cancelled() }}
+    uses: ./.github/workflows/tools-windows.yml
   build:
     needs: tools
     if: ${{ !failure() && !cancelled() }}
@@ -47,7 +51,7 @@ jobs:
 #    needs: build
 #    if: ${{ !failure() && !cancelled() }}
 #    uses: ./.github/workflows/macos_m1.yml
-#  windows:
-#    needs: build
-#    if: ${{ !failure() && !cancelled() }}
-#    uses: ./.github/workflows/windows.yml
+  windows:
+    needs: tools-windows
+    if: ${{ !failure() && !cancelled() }}
+    uses: ./.github/workflows/windows.yml

.github/workflows/mariadb.yml

@@ -19,13 +19,16 @@ jobs:
     timeout-minutes: 30
     strategy:
       matrix:
-        CC: [gcc]
+        CC: [gcc-15]
         RENEWAL: [""]
         CLIENT_TYPE: [""]
         HTTPLIB: ["", "-DWITH_HTTP_PARSER=llhttp"]
         SANITIZER: ["-DMEMORY_MANAGER=none", "-DMEMORY_MANAGER=none -DENABLE_SANITIZE=ON"]
         PACKET_VERSION: ["-DPACKETVER=20221024"]
         MYSQL: ["10.11", "11.8", "latest"]
+        include:
+          - CXX: 'g++-15'
+            CC: 'gcc-15'
 
     # github.head_ref will stop previous runs in the same PR (if in a PR)
     # github.run_id is a fallback when outside a PR (e.g. every merge in master will run, and previous won't stop)
@@ -51,10 +54,11 @@ jobs:
           --health-timeout=2s
           --health-retries=3
     env:
-      INSTALL_PACKAGES: ${{ matrix.CC }} mariadb-client
+      INSTALL_PACKAGES: ${{ matrix.CC }} ${{ matrix.CXX }} mariadb-client
       SQLHOST: mysql
       CC: ${{ matrix.CC }}
-      CONFIGURE_FLAGS: -DCMAKE_C_COMPILER=${{ matrix.CC }} -DCMAKE_BUILD_TYPE=Debug -DENABLE_WERROR=ON -DENABLE_BUILDBOT=ON ${{ matrix.RENEWAL }} ${{ matrix.HTTPLIB }} ${{ matrix.CLIENT_TYPE }} ${{ matrix.SANITIZER }} ${{ matrix.PACKET_VERSION }} -DBUILD_HPMHOOKING=ON
+      CXX: ${{ matrix.CXX }}
+      CONFIGURE_FLAGS: -DCMAKE_C_COMPILER=${{ matrix.CC }} -DCMAKE_CXX_COMPILER=${{ matrix.CXX }} -DCMAKE_BUILD_TYPE=Debug -DENABLE_WERROR=ON -DENABLE_BUILDBOT=ON ${{ matrix.RENEWAL }} ${{ matrix.HTTPLIB }} ${{ matrix.CLIENT_TYPE }} ${{ matrix.SANITIZER }} ${{ matrix.PACKET_VERSION }} -DBUILD_HPMHOOKING=ON
       PACKET_VERSION: ${{ matrix.PACKET_VERSION }}
     steps:
       - uses: actions/checkout@v6
@@ -65,6 +69,13 @@ jobs:
         run: |
           uname -a
 
+      - uses: actions/cache/restore@v6
+        name: restore conan cache
+        id: cache
+        with:
+          path: ~/.conan2
+          key: ${{ runner.os }}-${{ matrix.CC }}-${{ hashFiles('conanfile.py') }}
+
       - name: install packages
         run: |
           ./tools/ci/retry.sh apt-get update

.github/workflows/sanitizer.yml

@@ -7,7 +7,7 @@ env:
   MYSQL_USER: 'ragnarok'
   MYSQL_PASSWORD: 'ragnarok'
   MYSQL_ALLOW_EMPTY_PASSWORD: 'yes'
-  DEBIAN_COMMON_PACKAGES: cmake make git python3 python3-venv libzstd-dev g++
+  DEBIAN_COMMON_PACKAGES: cmake make git python3 python3-venv libzstd-dev
 
 defaults:
   run:
@@ -19,7 +19,7 @@ jobs:
     timeout-minutes: 30
     strategy:
       matrix:
-        CC: [gcc]
+        CC: [gcc-15]
         RENEWAL: ["", "-DENABLE_RENEWAL=OFF"]
         CLIENT_TYPE: ["", "-DENABLE_PACKETVER_RE=ON", "-DENABLE_PACKETVER_ZERO=ON"]
         HTTPLIB: ["", "-DWITH_HTTP_PARSER=llhttp"]
@@ -32,6 +32,9 @@ jobs:
           - PACKET_VERSION: "-DPACKETVER=20130724"
             RENEWAL: ""
             CLASSIC_AUTOSPELL_LIST: "-DENABLE_CLASSIC_AUTOSPELL=ON"
+          - CXX: 'g++-15'
+            CC: 'gcc-15'
+
         exclude:
           - PACKET_VERSION: "-DPACKETVER=20130724"
             CLIENT_TYPE: "-DENABLE_PACKETVER_ZERO=ON"
@@ -43,7 +46,7 @@ jobs:
       cancel-in-progress: true
 
     container:
-      image: ubuntu:24.04
+      image: ubuntu:26.04
     services:
       mariadb:
         image: mariadb:latest
@@ -60,10 +63,11 @@ jobs:
           --health-timeout=2s
           --health-retries=3
     env:
-      INSTALL_PACKAGES: ${{ matrix.CC }} mariadb-client
+      INSTALL_PACKAGES: ${{ matrix.CC }} ${{ matrix.CXX }} mariadb-client
       SQLHOST: mariadb
       CC: ${{ matrix.CC }}
-      CONFIGURE_FLAGS: -DCMAKE_C_COMPILER=${{ matrix.CC }} -DCMAKE_BUILD_TYPE=Debug -DENABLE_WERROR=ON -DENABLE_BUILDBOT=ON ${{ matrix.RENEWAL }} ${{ matrix.HTTPLIB }} ${{ matrix.CLIENT_TYPE }} ${{ matrix.SANITIZER }} ${{ matrix.PACKET_VERSION }} -DENABLE_LTO=ON ${{ matrix.CLASSIC_AUTOSPELL_LIST }} -DBUILD_HPMHOOKING=ON
+      CXX: ${{ matrix.CXX }}
+      CONFIGURE_FLAGS: -DCMAKE_C_COMPILER=${{ matrix.CC }} -DCMAKE_CXX_COMPILER=${{ matrix.CXX }} -DCMAKE_BUILD_TYPE=Debug -DENABLE_WERROR=ON -DENABLE_BUILDBOT=ON ${{ matrix.RENEWAL }} ${{ matrix.HTTPLIB }} ${{ matrix.CLIENT_TYPE }} ${{ matrix.SANITIZER }} ${{ matrix.PACKET_VERSION }} -DENABLE_LTO=ON ${{ matrix.CLASSIC_AUTOSPELL_LIST }} -DBUILD_HPMHOOKING=ON
       PACKET_VERSION: ${{ matrix.PACKET_VERSION }}
     steps:
       - uses: actions/checkout@v6
@@ -74,6 +78,13 @@ jobs:
         run: |
           uname -a
 
+      - uses: actions/cache/restore@v6
+        name: restore conan cache
+        id: cache
+        with:
+          path: ~/.conan2
+          key: ${{ runner.os }}-${{ matrix.CC }}-${{ hashFiles('conanfile.py') }}
+
       - name: install packages
         run: |
           ./tools/ci/retry.sh apt-get update

.github/workflows/tools-windows.yml

@@ -0,0 +1,43 @@
+name: tools-windows
+
+on: workflow_call
+
+jobs:
+  build:
+    runs-on: windows-2025
+    timeout-minutes: 30
+    strategy:
+      matrix:
+        CC: [msvc]
+
+    # github.head_ref will stop previous runs in the same PR (if in a PR)
+    # github.run_id is a fallback when outside a PR (e.g. every merge in master will run, and previous won't stop)
+    concurrency:
+      group: tools-windows-${{ github.head_ref || github.run_id }}_${{ matrix.CC }}
+      cancel-in-progress: true
+
+    steps:
+      - uses: actions/checkout@v6
+        with:
+          fetch-depth: 1
+
+      - uses: actions/cache/restore@v6 # We're restoring first so if a cache already exists from previous CI run, it's used and step finishes quicker.
+        name: restore conan cache
+        id: cache-restore
+        with:
+          path: ~/.conan2
+          key: ${{ runner.os }}-${{ matrix.CC }}-${{ hashFiles('conanfile.py') }}
+
+      - name: run cmake first run
+        if: steps.cache-restore.outputs.cache-hit != 'true'
+        run: |
+          ./setup_env.ps1
+
+      - uses: actions/cache/save@v6
+        if: steps.cache-restore.outputs.cache-hit != 'true'
+        name: save conan cache
+        id: cache_save
+        with:
+          path: ~/.conan2
+          key: ${{ runner.os }}-${{ matrix.CC }}-${{ hashFiles('conanfile.py') }}
+

.github/workflows/tools.yml

@@ -7,20 +7,31 @@ env:
   MYSQL_USER: 'ragnarok'
   MYSQL_PASSWORD: 'ragnarok'
   MYSQL_ALLOW_EMPTY_PASSWORD: 'yes'
-  DEBIAN_COMMON_PACKAGES: python3 python3-pip
+  DEBIAN_COMMON_PACKAGES: python3 python3-pip python3-venv cmake make git gcc g++
 
 jobs:
   build:
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        shell: bash
+    strategy:
+      matrix:
+        CC: ["clang-21", "gcc-15"]
+        include:
+          - CXX: 'g++-15'
+            CC: 'gcc-15'
+          - CXX: 'clang++-21'
+            CC: 'clang-21'
 
     # github.head_ref will stop previous runs in the same PR (if in a PR)
     # github.run_id is a fallback when outside a PR (e.g. every merge in master will run, and previous won't stop)
     concurrency:
-      group: tools-${{ github.head_ref || github.run_id }}
+      group: tools-linux-${{ github.head_ref || github.run_id }}_${{ matrix.CC }}
       cancel-in-progress: true
 
     container:
-      image: debian:unstable
+      image: ubuntu:26.04
     steps:
       - uses: actions/checkout@v6
         with:
@@ -33,9 +44,31 @@ jobs:
       - name: install packages
         run: |
           ./tools/ci/retry.sh apt-get update
-          ./tools/ci/retry.sh apt-get install -y -qq $INSTALL_PACKAGES $DEBIAN_COMMON_PACKAGES
+          ./tools/ci/retry.sh apt-get install -y -qq $INSTALL_PACKAGES $DEBIAN_COMMON_PACKAGES ${{ matrix.CC }} ${{ matrix.CXX }}
           pip3 install sqlfluff --break-system-packages
 
+      - uses: actions/cache/restore@v6 # We're restoring first so if a cache already exists from previous CI run, it's used and step finishes quicker.
+        name: restore conan cache
+        id: cache-restore
+        with:
+          path: ~/.conan2
+          key: ${{ runner.os }}-${{ matrix.CC }}-${{ hashFiles('conanfile.py') }}
+
+      - name: run cmake first run
+        if: steps.cache-restore.outputs.cache-hit != 'true'
+        run: |
+          ./tools/ci/travis.sh prepareenv
+          source .venv/bin/activate
+          cmake -S . -B build -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=cmake_modules/conan_provider.cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=${{ matrix.CC }} -DCMAKE_CXX_COMPILER=${{ matrix.CXX }}
+
+      - uses: actions/cache/save@v6
+        if: steps.cache-restore.outputs.cache-hit != 'true'
+        name: save conan cache
+        id: cache_save
+        with:
+          path: ~/.conan2
+          key: ${{ runner.os }}-${{ matrix.CC }}-${{ hashFiles('conanfile.py') }}
+
       - name: check sql syntax
         run: |
           ./tools/ci/retry.sh python3 tools/validate_sql-files.py

.github/workflows/windows.yml

@@ -1,4 +1,4 @@
-name: windows
+name: build windows
 
 on: workflow_call
 
@@ -10,31 +10,47 @@ env:
 
 jobs:
   build:
-    runs-on: windows-latest
+    runs-on: windows-2025
     timeout-minutes: 30
     strategy:
       matrix:
-        CC: [msbuild]
-        RENEWAL: ["", "DISABLE_RENEWAL"]
-        CLIENT_TYPE: ["", "ENABLE_PACKETVER_RE", "ENABLE_PACKETVER_ZERO"]
-        PACKET_VERSION: ["PACKETVER=20221024", "PACKETVER=20130724"]
+        CC: [msvc]
+        RENEWAL: ["", "-DENABLE_RENEWAL=OFF"]
+        CLIENT_TYPE: ["", "-DENABLE_PACKETVER_RE=ON", "-DENABLE_PACKETVER_ZERO=ON"]
+        HTTPLIB: ["", "-DWITH_HTTP_PARSER=llhttp"]
+        PACKET_VERSION: ["-DPACKETVER=20221024", "-DPACKETVER=20130724"]
+        include:
+          # Empty CLASSIC_AUTOSPELL_LIST for every other flow
+          - CLASSIC_AUTOSPELL_LIST: ""
+          # Use "-DCLASSIC_AUTOSPELL_LIST" for 20130724 RE or we will get warnings due to the list being too small
+          - PACKET_VERSION: "-DPACKETVER=20130724"
+            RENEWAL: ""
+            CLASSIC_AUTOSPELL_LIST: "-DENABLE_CLASSIC_AUTOSPELL=ON"
         exclude:
-          - PACKET_VERSION: "PACKETVER=20130724"
-            CLIENT_TYPE: "ENABLE_PACKETVER_ZERO"
+          - PACKET_VERSION: "-DPACKETVER=20130724"
+            CLIENT_TYPE: "-DENABLE_PACKETVER_ZERO=ON"
 
     # github.head_ref will stop previous runs in the same PR (if in a PR)
     # github.run_id is a fallback when outside a PR (e.g. every merge in master will run, and previous won't stop)
     concurrency:
-      group: msbuild-${{ github.head_ref || github.run_id }}_${{ matrix.CC }}_${{ matrix.RENEWAL }}_${{ matrix.CLIENT_TYPE }}_${{ matrix.PACKET_VERSION}}
+      group: build_windows-${{ github.head_ref || github.run_id }}_${{ matrix.CC }}_${{ matrix.RENEWAL }}_${{ matrix.CLIENT_TYPE }}_${{ matrix.HTTPLIB }}_${{ matrix.PACKET_VERSION}}
       cancel-in-progress: true
 
     steps:
       - uses: actions/checkout@v6
         with:
           fetch-depth: 1
 
-      - name: Add msbuild to PATH
-        uses: microsoft/setup-msbuild@v2
+#      - name: install packages
+#        run: |
+#          winget install Ninja-build.Ninja cmake python3 --accept-source-agreements --accept-package-agreements --disable-interactivity --silent
+
+      - uses: actions/cache/restore@v6
+        name: restore conan cache
+        id: cache
+        with:
+          path: ~/.conan2
+          key: ${{ runner.os }}-${{ matrix.CC }}-${{ hashFiles('conanfile.py') }}
 
       - uses: shogo82148/actions-setup-mysql@v1
         with:
@@ -51,13 +67,13 @@ jobs:
 
       - name: build
         run: |
-          .\tools\ci\windows.ps1 build ${{ matrix.CLIENT_TYPE }} ${{ matrix.PACKET_VERSION}} ${{ matrix.RENEWAL }}
+          .\tools\ci\windows.ps1 build ${{ matrix.CLIENT_TYPE }} ${{ matrix.PACKET_VERSION}} ${{ matrix.RENEWAL }} ${{ matrix.HTTPLIB }} ${{ matrix.CLASSIC_AUTOSPELL_LIST }} -DENABLE_WERROR=ON -DENABLE_BUILDBOT=ON -DBUILD_HPMHOOKING=ON
 
       - name: run
         run: |
           .\tools\ci\windows.ps1 run
 
       - name: test
-        if: matrix.PACKET_VERSION != 'PACKETVER=20130724'
+        if: matrix.PACKET_VERSION != '-DPACKETVER=20130724'
         run: |
           .\tools\ci\windows.ps1 test

3rdparty/http-parser/CMakeLists.txt

@@ -41,4 +41,6 @@ add_library(hercules-http_parser STATIC
 
 if(NOT MSVC)
   target_compile_options(hercules-http_parser PRIVATE -Wno-shadow -Wno-switch-enum)
+else()
+  target_compile_options(hercules-http_parser PRIVATE /wd4456)
 endif()