Part 1: Removal of various warnings supression and fixing their warnings, chagning class and delete C++ keywords in names, and changes related to compile common target as C++#3416
Open
hemagx wants to merge 62 commits into
Conversation
MishimaHaruna
force-pushed
the
compile_cpp
branch
2 times, most recently
from
7d4d5d5 to
6f49cfa
Compare
hemagx
force-pushed
the
compile_cpp
branch
12 times, most recently
from
a9a16d4 to
51c9aac
Compare
hemagx
force-pushed
the
compile_cpp
branch
10 times, most recently
from
505d167 to
6382e17
Compare
Warnings reported by clangd/clang-tidy Signed-off-by: Haru <haru@dotalux.com>
Signed-off-by: Haru <haru@dotalux.com>
Signed-off-by: Haru <haru@dotalux.com>
Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
…use of a packet structure Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
…erated bison code
…the logic to return early
…se after a return
…nging the logic to return early
…ll_check_condition_char_sub
… easier and remove extra indentation
…ns caused by code after disp_error_message() The warning is suppressed instead of removing the dead code because in debug builds it fails to detect that disp_error_message never returns
…d in debug builds
* According to original author the code might have been a left over from a previous fix, a test was conducted and confirmed the code isn't required. Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
…hat reports intended behavior/features Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
and openssl on other platforms Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
dependencies and caches them for use in later builds, improving build speed. Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
The following warnings suppression has been removed and their warnings were fixed:
The following keywords has been changed in source:
class->class_delete->delete_new->new_ERS now has ownership over the name given to it, and similarly various functions that were taking
char *and expecting constant strings were changed to takeconst char *Issues addressed: