Repository navigation
fix(transfer): list transfers of every wallet the account has - #603
Merged
dadiorchen merged 1 commit intoSep 29, 2026
Merged
Conversation
The transfers list filtered on the login wallet alone, so a transfer sent to any other wallet of the account matched nothing. The recipient never saw it, could not accept it, and the sender's tokens sat pending with only the sender able to cancel. The filter now covers every wallet getAllWallets returns, which since Greenstand#590 is the account's own wallets plus any it manages. The list is seeded with the login wallet before the others are added: knex drops an empty `or`, and the ownership restriction would go with it. Closes Greenstand/treetracker-wallet-app#852
|
🎉 This PR is included in version 1.44.0-keycloak.38 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Greenstand/treetracker-wallet-app#852
Problem
The transfers list filtered on the login wallet alone, so a transfer sent to any other wallet of the account matched nothing. The recipient never saw it, could not accept it, and the sender's tokens sat pending with only the sender able to cancel
Change
The filter now covers every wallet
getAllWalletsreturns, which since #590 is the account's own wallets plus any it manages. #563 did this before the rollbackThe list is seeded with the login wallet before the others are added: knex drops an empty
or, and the ownership restriction would go with it, returning every transfer in the tableVerification