Repository navigation
fix(transfer): handle decline and cancel across wallets - #601
Open
hariclerry wants to merge 1 commit into
Open
hariclerry wants to merge 1 commit into
hariclerry wants to merge 1 commit into
Conversation
Collaborator
|
@samwel141 can you help review this? |
Collaborator
|
@hariclerry you'll need to rebase onto keycloak and switch the base, it's still targeting master. |
Collaborator
|
But also its not a blocker it can be merged after release @dadiorchen, @mahdi2ba also mentioned in the issue #599 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix transfer decline and cancellation failures when a transfer belongs to a second wallet owned by the same account.
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
originating_walletfromundefined.What is the new behavior?
Decline and cancel now use the existing transfer lookup helper. This preserves
the account wallet visibility and authorization checks and returns a controlled
404when the transfer is not found or is not related to the requesting account.Added regression tests covering missing transfers for both decline and cancel,
including transaction rollback and prevention of mutation or event logging.
Breaking change
Does this PR introduce a breaking change?
Other useful information
keycloakor `master