Skip to content

Upgrade to v3.9.9-rc3 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
varun-doshi wants to merge 1 commit into
base: v3.9.9-rc3
Choose a base branch
from
Draft

Upgrade to v3.9.9-rc3 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 4 additions & 32 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,5 @@
# Lines starting with '#' are comments.
# Each line is a file pattern followed by one or more owners.
# These owners will be the default owners for everything in the repo. Unless a
# later match takes precedence, they will be requested for review when someone
# opens a pull request.

accounts/usbwallet/ @gballet
accounts/scwallet/ @gballet
accounts/abi/ @gballet @MariusVanDerWijden
beacon/engine/ @MariusVanDerWijden @lightclient @fjl
beacon/light/ @zsfelfoldi
beacon/merkle/ @zsfelfoldi
beacon/types/ @zsfelfoldi @fjl
beacon/params/ @zsfelfoldi @fjl
cmd/evm/ @MariusVanDerWijden @lightclient
core/state/ @rjl493456442
crypto/ @gballet @jwasinger @fjl
core/ @rjl493456442
eth/ @rjl493456442
eth/catalyst/ @MariusVanDerWijden @lightclient @fjl @jwasinger
eth/tracers/ @s1na
ethclient/ @fjl
ethdb/ @rjl493456442
event/ @fjl
trie/ @rjl493456442 @gballet
triedb/ @rjl493456442
core/tracing/ @s1na
graphql/ @s1na
internal/ethapi/ @fjl @s1na @lightclient
internal/era/ @lightclient
miner/ @MariusVanDerWijden @fjl @rjl493456442
node/ @fjl
p2p/ @fjl @zsfelfoldi
rlp/ @fjl
params/ @fjl @gballet @rjl493456442 @zsfelfoldi
rpc/ @fjl
* @ImJeremyHe @zacshowa @Sneh1999 @philippecamacho @jjeangal
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Replacing granular code ownership with a global wildcard (*) significantly reduces the effectiveness of the CODEOWNERS feature. The previous configuration ensured that specialized components (e.g., crypto/, p2p/, core/state/) were reviewed by their respective experts. Consolidating all ownership to a single group may lead to lower quality reviews or security oversights in specialized areas. It is recommended to retain specific owners for critical subsystems.

9 changes: 9 additions & 0 deletions core/rawdb/espresso_freezer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package rawdb

func NewEspressoTableConfig(tables map[string]bool) map[string]freezerTableConfig {
result:= make(map[string]freezerTableConfig)
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are two improvements for this line: 1. Style: Add a space before the := operator to adhere to standard Go formatting (gofmt). 2. Efficiency: Initialize the map with a capacity equal to len(tables) to avoid unnecessary memory re-allocations as the map grows.

Suggested change
result:= make(map[string]freezerTableConfig)
result := make(map[string]freezerTableConfig, len(tables))
References
  1. Go code should be formatted according to the standard 'gofmt' rules, which include proper spacing around operators like ':=' . (link)

for key, value := range tables {
result[key] = freezerTableConfig{noSnappy: value, prunable: true}
}
return result
}
Loading