Upgrade to v3.9.9-rc3#11
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces granular code ownership with a global wildcard in the .github/CODEOWNERS file and introduces a new NewEspressoTableConfig function in core/rawdb/espresso_freezer.go. Feedback highlights that the loss of specific owners for critical subsystems may reduce review quality. Additionally, improvements were suggested for the new Go code to adhere to standard formatting and optimize map initialization by pre-allocating capacity.
| rlp/ @fjl | ||
| params/ @fjl @gballet @rjl493456442 @zsfelfoldi | ||
| rpc/ @fjl | ||
| * @ImJeremyHe @zacshowa @Sneh1999 @philippecamacho @jjeangal |
There was a problem hiding this comment.
Replacing granular code ownership with a global wildcard (*) significantly reduces the effectiveness of the CODEOWNERS feature. The previous configuration ensured that specialized components (e.g., crypto/, p2p/, core/state/) were reviewed by their respective experts. Consolidating all ownership to a single group may lead to lower quality reviews or security oversights in specialized areas. It is recommended to retain specific owners for critical subsystems.
| package rawdb | ||
|
|
||
| func NewEspressoTableConfig(tables map[string]bool) map[string]freezerTableConfig { | ||
| result:= make(map[string]freezerTableConfig) |
There was a problem hiding this comment.
There are two improvements for this line: 1. Style: Add a space before the := operator to adhere to standard Go formatting (gofmt). 2. Efficiency: Initialize the map with a capacity equal to len(tables) to avoid unnecessary memory re-allocations as the map grows.
| result:= make(map[string]freezerTableConfig) | |
| result := make(map[string]freezerTableConfig, len(tables)) |
References
- Go code should be formatted according to the standard 'gofmt' rules, which include proper spacing around operators like ':=' . (link)
Puts espresso-integration on top on
v3.9.9-rc3