Skip to content

Upgrade to v3.9.9-rc3#11

Draft
varun-doshi wants to merge 1 commit into
v3.9.9-rc3from
vd/upgrade-v3.9.9
Draft

Upgrade to v3.9.9-rc3#11
varun-doshi wants to merge 1 commit into
v3.9.9-rc3from
vd/upgrade-v3.9.9

Conversation

@varun-doshi
Copy link
Copy Markdown

Puts espresso-integration on top on v3.9.9-rc3

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces granular code ownership with a global wildcard in the .github/CODEOWNERS file and introduces a new NewEspressoTableConfig function in core/rawdb/espresso_freezer.go. Feedback highlights that the loss of specific owners for critical subsystems may reduce review quality. Additionally, improvements were suggested for the new Go code to adhere to standard formatting and optimize map initialization by pre-allocating capacity.

Comment thread .github/CODEOWNERS
rlp/ @fjl
params/ @fjl @gballet @rjl493456442 @zsfelfoldi
rpc/ @fjl
* @ImJeremyHe @zacshowa @Sneh1999 @philippecamacho @jjeangal
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Replacing granular code ownership with a global wildcard (*) significantly reduces the effectiveness of the CODEOWNERS feature. The previous configuration ensured that specialized components (e.g., crypto/, p2p/, core/state/) were reviewed by their respective experts. Consolidating all ownership to a single group may lead to lower quality reviews or security oversights in specialized areas. It is recommended to retain specific owners for critical subsystems.

package rawdb

func NewEspressoTableConfig(tables map[string]bool) map[string]freezerTableConfig {
result:= make(map[string]freezerTableConfig)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are two improvements for this line: 1. Style: Add a space before the := operator to adhere to standard Go formatting (gofmt). 2. Efficiency: Initialize the map with a capacity equal to len(tables) to avoid unnecessary memory re-allocations as the map grows.

Suggested change
result:= make(map[string]freezerTableConfig)
result := make(map[string]freezerTableConfig, len(tables))
References
  1. Go code should be formatted according to the standard 'gofmt' rules, which include proper spacing around operators like ':=' . (link)

@varun-doshi varun-doshi changed the title Upgrade to v3.9.9 Upgrade to v3.9.9-rc3 May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant