Skip to content

Add Custom Fee Rate for Channel Opening and Withdrawal - #152

Merged
ShahanaFarooqui merged 3 commits into
ElementsProject:Release-26.04from
ShahanaFarooqui:custom-fee-rate
Mar 9, 2026
Merged

Add Custom Fee Rate for Channel Opening and Withdrawal#152
ShahanaFarooqui merged 3 commits into
ElementsProject:Release-26.04from
ShahanaFarooqui:custom-fee-rate

Conversation

@ShahanaFarooqui

@ShahanaFarooqui ShahanaFarooqui commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Closes #36

@ShahanaFarooqui
ShahanaFarooqui force-pushed the custom-fee-rate branch 2 times, most recently from 9b405f7 to 9bfc017 Compare March 6, 2026 00:07
@ShahanaFarooqui
ShahanaFarooqui merged commit 53f027e into ElementsProject:Release-26.04 Mar 9, 2026
3 checks passed
@ShahanaFarooqui ShahanaFarooqui linked an issue Mar 10, 2026 that may be closed by this pull request
Manual setting fees #36
Closed
@8144225309 8144225309 mentioned this pull request May 29, 2026
Merged
8144225309 referenced this pull request in 8144225309/superscalar-wallet May 29, 2026
@8144225309
feat(factories+connect): Discard button (#150 wallet) + My Join Attem…
14e0cc9 
…pts view (#152 wallet) (#49)

Combined wallet half for two plugin RPCs that just landed:
  - factory-forget (superscalar-cln PR #76 / task #150 plugin half)
  - client-list-outgoing-joins (superscalar-cln PR #77 / task #152 plugin half)

#150 wallet half - Discard button on FactoryList
- Adds a Discard button next to Hide on each FactoryListItem, only shown
  when the factory qualifies for the plugin's factory-forget RPC:
    * lifecycle is FAILED or ABORTED (or ceremony=FAILED as a fallback
      for the brief window before the plugin auto-transitions the
      client side), AND
    * funding_txid has no non-zero hex chars (the plugin's zero-onchain-
      footprint gate), AND
    * n_channels === 0.
- Wires it to FactoriesService.forgetFactory + a refetch of the factory
  list on success. Per-item busy state via discardingIds Set so rapid
  clicks don't double-fire.
- Adds FactoryLifecycle.FAILED to the TS enum so PR #74's auto-
  terminalized factories render correctly (string mapping +
  bucketOf -> 'incomplete').

#152 wallet half - "My join attempts" view on Connect page
- New MyJoinAttemptsCard component below ConnectList. Calls the new
  client-list-outgoing-joins RPC, renders a status-badged table of
  every factory-join-request the client has fired (instance_id +
  lsp_node_id truncated, requested sats, sent block, status, optional
  reason).
- Status badge color: warning (sent/queued/accepted), success (signed),
  danger (rejected/cancelled/timeout), info (already_member).
- Empty state + manual Refresh button. Suppresses the noisy "method
  not found" before plugin upgrade ships with a clear hint pointing at
  PR #77.

Plumbing:
- http.service.ts: new FactoriesService.forgetFactory(instanceId) and
  FactoriesService.listOutgoingJoins() wrappers.

No behavior change for users on plugins that pre-date PRs #76 / #77;
the Discard button just stays hidden, and MyJoinAttemptsCard shows
the "Plugin does not expose ... yet" hint instead of a noisy crash.
8144225309 referenced this pull request in 8144225309/superscalar-wallet May 29, 2026
@8144225309
fix(csp): allow style-src 'unsafe-inline' (#158) (#50)
92d6cc4 
* feat(factories+connect): Discard button (#150 wallet) + My Join Attempts view (#152 wallet)

Combined wallet half for two plugin RPCs that just landed:
  - factory-forget (superscalar-cln PR #76 / task #150 plugin half)
  - client-list-outgoing-joins (superscalar-cln PR #77 / task #152 plugin half)

#150 wallet half - Discard button on FactoryList
- Adds a Discard button next to Hide on each FactoryListItem, only shown
  when the factory qualifies for the plugin's factory-forget RPC:
    * lifecycle is FAILED or ABORTED (or ceremony=FAILED as a fallback
      for the brief window before the plugin auto-transitions the
      client side), AND
    * funding_txid has no non-zero hex chars (the plugin's zero-onchain-
      footprint gate), AND
    * n_channels === 0.
- Wires it to FactoriesService.forgetFactory + a refetch of the factory
  list on success. Per-item busy state via discardingIds Set so rapid
  clicks don't double-fire.
- Adds FactoryLifecycle.FAILED to the TS enum so PR #74's auto-
  terminalized factories render correctly (string mapping +
  bucketOf -> 'incomplete').

#152 wallet half - "My join attempts" view on Connect page
- New MyJoinAttemptsCard component below ConnectList. Calls the new
  client-list-outgoing-joins RPC, renders a status-badged table of
  every factory-join-request the client has fired (instance_id +
  lsp_node_id truncated, requested sats, sent block, status, optional
  reason).
- Status badge color: warning (sent/queued/accepted), success (signed),
  danger (rejected/cancelled/timeout), info (already_member).
- Empty state + manual Refresh button. Suppresses the noisy "method
  not found" before plugin upgrade ships with a clear hint pointing at
  PR #77.

Plumbing:
- http.service.ts: new FactoriesService.forgetFactory(instanceId) and
  FactoriesService.listOutgoingJoins() wrappers.

No behavior change for users on plugins that pre-date PRs #76 / #77;
the Discard button just stays hidden, and MyJoinAttemptsCard shows
the "Plugin does not expose ... yet" hint instead of a noisy crash.

* fix(csp): allow style-src 'unsafe-inline' (#158)

react-perfect-scrollbar injects <style> tags at runtime when its
PerfectScrollbar wrapper mounts. The previous strict
`style-src 'self'` policy blocked these injections, which broke
the Dashboard and any other page using PerfectScrollbar
(Channels card, AccountEvents, FactoryList, ConnectList, etc.).

Adding 'unsafe-inline' for style-src only — script-src stays
strict, so the XSS surface remains negligible. The library is a
transitive dependency; the cleaner long-term fix is to migrate
off it, but that's a separate refactor.

Rationale comment added inline so future maintainers don't
re-tighten the policy without removing the library first.
@8144225309 8144225309 mentioned this pull request May 30, 2026
Merged
8144225309 referenced this pull request in 8144225309/superscalar-wallet May 30, 2026
@8144225309
docs: JSDoc on remaining connect components (R5.27) (#149)
996e5ed 
Extends R5.x JSDoc to four remaining connect-layer components:

- ManualConnectModal: task #119 pubkey@host:port form filling the
  rendezvous vs invite-URL gap
- MyJoinAttemptsCard: task #152 outgoing-join audit; "did my join
  go through?" without grepping CLN logs
- GossipPill: status pill explaining why discovery may seem thin
  when the local CLN gossip view is small
- RendezvousSettings: Nostr relay + coordinator config; documents
  the per-network coordinator + per-tier caps flow

Connect layer now fully documented. Round 17 complete (8 PRs:
R5.20-R5.27).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Manual setting fees

1 participant

@ShahanaFarooqui