R5.27: JSDoc on remaining connect components - #149
Merged
Conversation
Extends R5.x JSDoc to four remaining connect-layer components: - ManualConnectModal: task #119 pubkey@host:port form filling the rendezvous vs invite-URL gap - MyJoinAttemptsCard: task #152 outgoing-join audit; "did my join go through?" without grepping CLN logs - GossipPill: status pill explaining why discovery may seem thin when the local CLN gossip view is small - RendezvousSettings: Nostr relay + coordinator config; documents the per-network coordinator + per-tier caps flow Connect layer now fully documented. Round 17 complete (8 PRs: R5.20-R5.27).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the connect-layer JSDoc sweep. ManualConnectModal (#119 gap), MyJoinAttemptsCard (#152 outgoing audit), GossipPill (discovery context), RendezvousSettings (Nostr config). Round 17 complete.