Skip to content

Pridavam nové komponenty #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MizuRyzu wants to merge 4 commits into
base: 4.x
Choose a base branch
from
Open

Pridavam nové komponenty #1

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e747dd
komponenta empty
MizuRyzu Nov 13, 2023
ec4b8e2
Komponenta error code
MizuRyzu Nov 13, 2023
f56c262
Oprava chýb v kóde
MizuRyzu Nov 15, 2023
0eaaf5e
Snad uz hotovo. :)
MizuRyzu Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions components/gov-empty/gov-empty.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{# empty
## Variables ##
# empty_icon – Optional. Adds svg icon before the label text.
# empty_title - nadpis komponenty
# empty_text - popisny text komponenty
# empty_button_aria_label - popis pro ctecky obrazu
# empty_button_text - text tlacitka
#}
<div align="left" class="gov-empty">
<div class="gov-empty__icon">
<div class="gov-icon">
<span class="gov-icon__holder">
{{ empty_icon }}
</span>
</div>
</div>
<div class="gov-empty__content">
<p class="gov-text--2xl">{{ empty_title }}</p>
<p class="gov-text--m gov-color--secondary-700">{{ empty_text }}</p>
<div size="l" class="gov-spacer"></div>
<div variant="primary" size="m" type="solid" hoverable="" class="gov-button"><button class="element" type="button" tabindex="0" aria-label="{{ empty_button_aria_label }}" aria-pressed="false" aria-disabled="false">{{ empty_button_text }}</button>
</div>
</div>
</div>
24 changes: 24 additions & 0 deletions components/gov-error-code/gov-error-code.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{# error code
## Variables ##
# error_code_icon – Optional. Adds svg icon before the label text.
# error_code_title - nadpis komponenty
# error_code_text - popisny text komponenty
# error_code_button_aria_label - popis pro ctecky obrazu
# error_code_button_text - text tlacitka
#}
<div class="gov-error-code__holder">
<div class="gov-error-code__icon">
<div class="gov-icon">
<span class="gov-icon__holder">
{{ error_code_icon }}
</span>
</div>
</div>
<div class="gov-error-code__content">
<h2 class="gov-text--6xl">{{ error_code_title }}</h2>
<p class="gov-text--l">{{ error_code_text }}</p>
<div size="l" class="gov-spacer"></div>
<div variant="primary" size="m" type="solid" hoverable="" class="gov-button"><button class="element" type="button" tabindex="0" aria-label="{{ error_code_arial_label }}" aria-pressed="false" aria-disabled="false">{{ error_code_button_text }}</button>

@petrillek petrillek Nov 15, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error_code_arial_label – není to ariaL, ale aria. Navíc nahoře v komentáři to máš jako error_code_button_aria_label (to je správně).

@petrillek petrillek Nov 15, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ještě ti tam chybí ten error_code_button_aria_label. ;)

</div>
</div>

@petrillek petrillek Nov 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Změnit indent ze 4 mezer na 2.

</div>