Pridavam nové komponenty#1
Open
MizuRyzu wants to merge 4 commits into
Open
Conversation
vytvoril som novu komponentu empty pre csgov
Vytvoril som novu komponentu error code pre csgov
petrillek
reviewed
Nov 14, 2023
| <div size="l" class="gov-spacer hydrated"></div> | ||
| <div variant="primary" size="m" type="solid" hoverable="" class="gov-button hydrated"><button class="element" type="button" tabindex="0" aria-label="{{ error_code_arial_label }}" aria-pressed="false" aria-disabled="false">{{ error_code_button_text }}</button> | ||
| </div> | ||
| </div> |
Member
There was a problem hiding this comment.
Změnit indent ze 4 mezer na 2.
petrillek
reviewed
Nov 15, 2023
| <div size="l" class="gov-spacer hydrated"></div> | ||
| <div variant="primary" size="m" type="solid" hoverable="" class="gov-button hydrated"><button class="element" type="button" tabindex="0" aria-label="{{ error_code_arial_label }}" aria-pressed="false" aria-disabled="false">{{ error_code_button_text }}</button> | ||
| <div size="l" class="gov-spacer"></div> | ||
| <div variant="primary" size="m" type="solid" hoverable="" class="gov-button"><button class="element" type="button" tabindex="0" aria-label="{{ error_code_arial_label }}" aria-pressed="false" aria-disabled="false">{{ error_code_button_text }}</button> |
Member
There was a problem hiding this comment.
error_code_arial_label – není to ariaL, ale aria. Navíc nahoře v komentáři to máš jako error_code_button_aria_label (to je správně).
Member
There was a problem hiding this comment.
Ještě ti tam chybí ten error_code_button_aria_label. ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.