Use StringUtil.ToLowerInvariant()/StringUtil.ToUpperInvariant() on .NET Framework - #9180
Open
andrewlock wants to merge 5 commits into
Open
Use StringUtil.ToLowerInvariant()/StringUtil.ToUpperInvariant() on .NET Framework#9180andrewlock wants to merge 5 commits into
StringUtil.ToLowerInvariant()/StringUtil.ToUpperInvariant() on .NET Framework#9180andrewlock wants to merge 5 commits into
Conversation
andrewlock
added
the
type:performance
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
andrewlock
marked this pull request as ready for review
September 4, 2026 10:03
andrewlock
requested review from
btthomas,
kathiehuang,
link04,
sameerank and
vandonr
and removed request for
a team
September 4, 2026 10:03
BenchmarksBenchmark execution time: 2026-09-08 08:26:19 Comparing candidate commit a715a1a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 74 known flaky benchmarks, 52 flaky benchmarks without significant changes.
|
Base automatically changed from
andrew/tolowerinvariant-optimizations
to
master
September 7, 2026 17:39
Makes it easier to replace usage sites
…net461 Adds a net461-only banned-symbols file to force using StringUtil on .NET Framework. The two IAST aspects intentionally keep calling the BCL directly
…ringUtil Switches every shared Datadog.Trace call site from the allocating BCL methods to StringUtil.ToUpperInvariant/ToLowerInvariant, so the non-allocating .NET Framework fast path added in previous commits actually gets used. Prepares for banning the raw BCL methods on net461.
…ringUtil on .NET Framework The EnumExtensions generator's fallback methods called string.ToUpperInvariant() directly in the generated code, which will trip the upcoming net461 ban on that BCL method. Emit a single private helper with an #if NETFRAMEWORK branch to StringUtil.ToUpperInvariant instead, and regenerate the four checked-in outputs.
andrewlock
force-pushed
the
andrew/use-new-tolowerinvariant
branch
from
September 8, 2026 07:37
3d7f80a to
a715a1a
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (9180) and master. ✅ No regressions detected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Updates .NET Framework code to use
StringUtil.ToLowerInvariant()/StringUtil.ToUpperInvariant()instead ofstring.ToLowerInvariant()/string.ToUpperInvariant()Reason for change
On .NET Framework
ToLowerInvariant()allocates, even if there's no change of case required. #9173 added a non-allocating version, but id dnot update call sites.This PR updates all the callsites to use the new method, and adds a BannedSymbols analyzer to force you to use it.
Implementation details
StringUtilfor non-.NET Framework usage#if NETFRAMEWORKeverywhere, basically pass throughStringUtilmethods to accept nullable string, to make it easier to updatex?.ToLowerInvariant()constructsNote it would also be possible to make the
StringUtilmethods be extension methods, but then we'd need to rename them, e.g.StringUtil.ToLowerInvariantSafe()or somethingTest coverage
Covered by existing tests
Other details
Stacked on
ToLowerInvariant()/ToUpperInvariant()for .NET Framework #9173Compare this to the alternative approach:
ToLowerInvariant()/ToUpperInvariant()interceptor for .NET Framework #9175Only one of those approaches will be merged!