Environment: Add env.js to data and set NODE_ENV var#115
Merged
Conversation
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment: Add env.js to data and set NODE_ENV var
Problem
Currently, all pages contain
<meta name="robots" content="noindex, nofollow">, which is determined byenv.production. We would like to set theenv.productionvariable properly.Solution
env.jsfile which containsNODE_ENVwhich selects the type of environmentNODE_ENVin thedeploy.ymljobResult
With the environment set to
production, content will no longer be set tonoindexandnofollow.Test Plan
Tested using personal fork and works! natalialuzuriaga.github.io/ospo_guide