Skip to content

upgrade CW packages to v2 - #840

Draft
noahsaso wants to merge 1 commit into
developmentfrom
cw-std-2
Draft

upgrade CW packages to v2#840
noahsaso wants to merge 1 commit into
developmentfrom
cw-std-2

Conversation

@noahsaso

@noahsaso noahsaso commented Jun 17, 2024

Copy link
Copy Markdown
Member

@noahsaso

Copy link
Copy Markdown
Member Author

blocked on public-awesome/cw-nfts#160

@mintthemoon

Copy link
Copy Markdown

I'm looking into this, there's a bit of a dependency snag to resolve here -- cw-nfts actually depends on this repo, for the cw-paginate-storage package: https://github.com/public-awesome/cw-nfts/blob/v0.19.0/Cargo.toml#L28

I can't get the cw721 package to compile without updating or removing this dependency. There's only one place the package is used and it only relies on the paginate_map_values query defined here.

Since it's only called once and the implementation is hardly any longer than the function call, maybe the best solution is to inline it and stop relying on the package?

@noahsaso

Copy link
Copy Markdown
Member Author

I'm looking into this, there's a bit of a dependency snag to resolve here -- cw-nfts actually depends on this repo, for the cw-paginate-storage package: https://github.com/public-awesome/cw-nfts/blob/v0.19.0/Cargo.toml#L28

I can't get the cw721 package to compile without updating or removing this dependency. There's only one place the package is used and it only relies on the paginate_map_values query defined here.

Since it's only called once and the implementation is hardly any longer than the function call, maybe the best solution is to inline it and stop relying on the package?

omg nooo, thank you for figuring this all out 🙏

i'm very down for that solution. it sounds best to me to depend on fewer packages if the reliance is so trivial.

@mintthemoon

Copy link
Copy Markdown

Actually I see they're not even using it for pagination now that I look closer at the implementation, passing None for both bounds. So I'd say that's definitely the way to go, code is much more clear without the indirection anyways.

@noahsaso

Copy link
Copy Markdown
Member Author

public-awesome/cw-nfts#160 was merged so this should be unblocked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants