cosmwasm v2 updates - #172
mintthemoon wants to merge 3 commits into
Conversation
|
Looking at those test runs, couple more updates I missed. Every single instance of |
| # TODO: switch to official https://github.com/larry0x/cw-plus-plus | ||
| # requires merge of https://github.com/larry0x/cw-plus-plus/pull/25 | ||
| cw-ownable = { git = "https://github.com/mintthemoon/cw-plus-plus", branch = "dev", package = "cw-ownable" } |
There was a problem hiding this comment.
Noticed that mentioned PR got merged 👀
| # TODO: switch to official https://github.com/larry0x/cw-plus-plus | |
| # requires merge of https://github.com/larry0x/cw-plus-plus/pull/25 | |
| cw-ownable = { git = "https://github.com/mintthemoon/cw-plus-plus", branch = "dev", package = "cw-ownable" } | |
| cw-ownable = { version = "^2.1" } |
|
Hey what is the progress on upgrade? We would like to use cw721 that supports cosmwasm v2!
Related to this issue CosmWasm/cosmwasm#2253 and for testing: CosmWasm/cw-multi-test#206 |
|
We are also looking to use cw721 in a cosmwasm v2 environment. Is there anything we can do to help? |
|
I'll have a look at it, until then pls resolve conflicts and rebase main branch |
|
@taitruong bumping here again! would be useful to have v2 support so standard nft dependencies can be used within the most recent cosmwasm version 👍 |
|
merged in #179 |
I got this a bit farther than #160 (and redid a bit of PFC's work when I should have merged it in 🙈 but there's plenty new), still a few outstanding concerns so I'll keep this as a draft.
cw-paginate-storage(upgrade CW packages to v2 DA0-DA0/dao-contracts#840).cargo/configto.cargo/config.tomlfor forwards compatibility (supports cargo 1.38+), resolves warningworkspace.resolver = "2", resolves warning (https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions)Outstanding issues:
cw721-fixed-price.cw-plus-pluspending merge of add multi-ownercw-ownablewith cosmwasm v2 larry0x/cw-plus-plus#25Other than the ones mentioned, all tests (that I could find) are passing. I likely won't have bandwidth to look into any of these issues for at least the rest of this week so if anyone wants to take a stab at them feel free.