Skip to content

Fix player walking on contraption causes lag (#9598) #10570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lzpoupl wants to merge 1 commit into
base: mc1.21.1/dev
Choose a base branch
from
+5 −2
Open

Fix player walking on contraption causes lag (#9598) #10570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...n/java/com/simibubi/create/foundation/mixin/client/EntityContraptionInteractionMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@
import net.minecraft.core.BlockPos;
import net.minecraft.core.particles.BlockParticleOption;
import net.minecraft.core.particles.ParticleTypes;
import net.minecraft.sounds.SoundEvent;
import net.minecraft.util.RandomSource;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.EntityDimensions;
import net.minecraft.world.entity.MoverType;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.RenderShape;
import net.minecraft.world.level.block.SoundType;
import net.minecraft.world.level.block.state.BlockState;
import net.minecraft.world.level.levelgen.structure.templatesystem.StructureTemplate;
import net.minecraft.world.phys.Vec3;
Expand All @@ -55,7 +57,7 @@ public abstract class EntityContraptionInteractionMixin {
protected abstract float nextStep();

@Shadow
protected abstract void playStepSound(BlockPos pos, BlockState state);
public abstract void playSound(SoundEvent sound, float volume, float pitch);

@Unique
private Stream<AbstractContraptionEntity> create$getIntersectionContraptionsStream() {
Expand Down Expand Up @@ -101,7 +103,8 @@ public abstract class EntityContraptionInteractionMixin {
MutableBoolean stepped = new MutableBoolean(false);

create$forCollision(worldPos, (contraption, state, pos) -> {
playStepSound(pos, state);
SoundType soundtype = state.getSoundType();
playSound(soundtype.getStepSound(), soundtype.getVolume() * 0.15F, soundtype.getPitch());
stepped.setTrue();
});

Expand Down