Fix player walking on contraption causes lag (#9598)

[lzpoupl]

Related issues: #9153 #4646 #9598 #6855

The bug appears to be caused by the contraption step sound Mixin

Create/src/main/java/com/simibubi/create/foundation/mixin/client/EntityContraptionInteractionMixin.java

Line 104 in fdfde66

playStepSound(pos, state);

mistakenly passing a contraption-local BlockPos into playStepSound(pos, state). For non-player entity like zombie, this method won't use the pos parameter, so nothing happens.

However, for players this dispatches to Player.playStepSound, which treats the position as a world position and performs additional level.getBlockState(...) lookups. Then, the server takes the local coordinates and interprets them as world coordinates, repeatedly querying a chunk near (0, 0) that is not loaded, which is an unnecessary cost and causes lag and extra memory usage.

Example of the coordinate mismatch:

player world position: (10003, 58, 10007)
contraption-local position: (3, 1, 7)
queried world chunk: (0, 0)

My solution now is to fall back to the implementation of Entity.playStepSound(). There might be a better solution, but I don't know much about minecraft sound engine and Mixin so I can't figure it out, though the cause of the bug is now clear.

A temporary workaround for this bug: /forceload the chunks around (0, 0) to mitigate the lag caused by repeated chunk loading.

I have another question. The Mixin class is in client package, so in theory it shouldn't cause server thread to lag, but it indeed does.

[lzpoupl]

@TqLxQuanZ Solution to your modpack lag issue