UI - Add map preview to Create MP Mission dialog - #1844
Merged
PabstMirror merged 2 commits intoAug 24, 2026
Merged
Conversation
Dystopian
commented
Aug 15, 2026
| _ctrlMaps setVariable [QGVAR(worldFeatures), _worldFeatures]; | ||
|
|
||
| ctrlPosition _ctrlMaps params ["_mapsLeft", "_mapsTop", "_mapsWidth", "_mapsHeight"]; | ||
| private _squareWidth = _mapsHeight * 3 / 4; |
Contributor
Author
There was a problem hiding this comment.
Please check this expression, because I completely do not understand how to correctly calculate it,
3/4 works for me, as well as safeZoneH / safeZoneW.
Contributor
There was a problem hiding this comment.
I wonder if the 3/4 refers to the 4:3 aspect ratio, which, as I understand it, safeZone{H,W} were designed to help abstract away.
rautamiekka
suggested changes
Aug 15, 2026
PabstMirror
reviewed
Aug 23, 2026
|
|
||
| ctrlPosition _ctrlMaps params ["_mapsLeft", "_mapsTop", "_mapsWidth", "_mapsHeight"]; | ||
| private _squareWidth = _mapsHeight * 3 / 4; | ||
| private _mapsWidthNew = _mapsWidth - _squareWidth; |
Contributor
There was a problem hiding this comment.
On square-ish aspect ratios this could possibly start to get cut-off
but I really don't think it will be a problem
we could do something like
if (_squareWidth > 0.5 * _mapsWidth) exitWith {}
to prevent the pic from taking too much of the horizontal,
but like I said I don't really think we need it unless someone has a problem
PabstMirror
approved these changes
Aug 23, 2026
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: