UI - Add remembering of last selected world and mission to Create MP Mission dialog - #1845
Open
Dystopian wants to merge 3 commits into
Open
UI - Add remembering of last selected world and mission to Create MP Mission dialog#1845Dystopian wants to merge 3 commits into
Dystopian wants to merge 3 commits into
Conversation
rautamiekka
reviewed
Aug 17, 2026
| _ctrlMissions lbSetPicture [_index, _picture]; | ||
| _ctrlMissions lbSetPictureRight [_index, _pictureRight]; | ||
| _ctrlMissions lbSetTooltip [_index, format ["%1", _data]]; | ||
| if (_selectIndex == -1 || {_data isEqualTo _lastMission}) then { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (_selectIndex == -1 || {_data isEqualTo _lastMission}) then { | |
| if (_selectIndex isEqualTo -1 || _data isEqualTo _lastMission) then { |
isEqualTo is faster than lazy eval. How big the _data is I don't have a clue, but it probly doesn't matter very much.
PabstMirror
reviewed
Aug 23, 2026
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Dystopian
force-pushed
the
add-remember-last-world
branch
from
August 24, 2026 08:01
04a87b0 to
fcc837c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Requires #1844 (shared code piece).