Repository navigation
Feature: Network configuration for Network Configuration Operators - #3608
Merged
Merged
Conversation
…3606) - Network Interface: members of the "Network Configuration Operators" group may change the network configuration without being an administrator, if NETworkManager runs elevated (IsInRole only reports enabled groups, so the check is only true in an elevated process). Only used by Network Interface; IsAdmin is unchanged for all other tools. - Errors of netsh/ipconfig are no longer ignored: each command's output and exit code are checked, the first failing command stops the operation and its (localized) message is shown instead of "applied successfully". Commands that would not change anything (DHCP/DNS autoconfiguration already enabled) are skipped, since netsh fails for them. - The admin hint is also shown as tooltip on the disabled "Apply" in the profile context menu, and mentions the group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Culture-specific resources override the updated permission hint with stale text that omits the newly supported group.
1 open finding
What changed in this PR
Enables Network Configuration Operators to manage network interfaces and improves command failure reporting.
Changes:
- Adds permission checks for administrators and Network Configuration Operators.
- Validates
netsh/ipconfigexit codes and displays failures. - Updates UI hints and documentation.
| File | Description |
|---|---|
Website/docs/changelog/next-release.md |
Records the permission and error-reporting changes. |
Website/docs/application/network-interface.md |
Documents elevation requirements and errors. |
Source/NETworkManager/Views/NetworkInterfaceView.xaml |
Adds permission-aware hints and visibility. |
Source/NETworkManager/ViewModels/NetworkInterfaceViewModel.cs |
Uses the expanded permission check. |
Source/NETworkManager.Models/Network/NetworkInterface.cs |
Implements permissions, state detection, and command validation. |
Source/NETworkManager.Localization/Resources/Strings.resx |
Expands the English permission hint. |
Source/NETworkManager.Localization/Resources/Strings.Designer.cs |
Updates generated resource documentation. |
Files not reviewed (1)
- Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Generated file
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| </data> | ||
| <data name="NetworkInterfaceConfigureAdminMessage" xml:space="preserve"> | ||
| <value>Configuring the network interface requires elevated rights!</value> | ||
| <value>Configuring the network interface requires elevated rights (administrator or member of the "Network Configuration Operators" group)!</value> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
To-Do
Contributing
By submitting this pull request, I confirm the following: