Conversation
…ter (BL-16548) Follow-up UI tweaks from QA on the Open / Create Collections dialog: - The team-collection icon shared the top-right corner with the hover "..." menu button, so the button covered the icon. Move the icon down into the left of the metadata row (beside the book count), leaving the corner to the "..." button. - The "..." menu showed the full .bloomCollection file path; show just the containing folder instead. The backend now returns a folderPath field; the card displays it (falling back to deriving it from path for stories/tests). - Darken the footer band (#fafafa -> #f0f0f0, border #eee -> #e0e0e0) so it is clearly distinguishable from the white dialog body. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
| Filename | Overview |
|---|---|
| src/BloomBrowserUI/collection/CollectionCard.tsx | Moves TeamCollectionIcon from the title row into the metadata row, adds folderPath derivation and display in the "…" menu. Logic is sound; fallback regex handles both Unix and Windows separators. |
| src/BloomBrowserUI/collection/CollectionChooserDialog.tsx | Two-line CSS tweak to darken footer background and border — straightforward and safe. |
| src/BloomExe/web/controllers/CollectionChooserApi.cs | Exposes the already-computed folderPath variable in the JSON response — a one-line addition with no behavioral side effects. |
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mas..." | Re-trigger Greptile
Member
Author
|
[Claude Opus 4.8] Consulted Devin on 2026-07-16 17:12 UTC up to commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up UI tweaks from Heather's QA pass on the Open / Create Collections dialog (the BL-16548 redesign).
Changes
.bloomCollectionfile. Backend now returns afolderPathfield; the card displays that (falling back to deriving it frompathfor stories/tests).#fafafa→#f0f0f0, border#eee→#e0e0e0) so it's clearly distinguishable from the white dialog body.Not included (deliberately)
Heather also reported that only 10 collections show at a time. That's the
maxMruItems = 10cap inCollectionChooserApi, but it's an intentional "most recently used" limit and changing it is a design decision (and has an eager-per-card book-count perf cost), so it's left out of this PR.Ref: https://issues.bloomlibrary.org/youtrack/issue/BL-16548
Devin review
This change is