Skip to content

Collection chooser dialog: fix TC-icon/menu overlap, folder path, footer (BL-16548)#8072

Draft
hatton wants to merge 2 commits into
masterfrom
BL-16548
Draft

Collection chooser dialog: fix TC-icon/menu overlap, folder path, footer (BL-16548)#8072
hatton wants to merge 2 commits into
masterfrom
BL-16548

Conversation

@hatton

@hatton hatton commented Jul 16, 2026

Copy link
Copy Markdown
Member

Follow-up UI tweaks from Heather's QA pass on the Open / Create Collections dialog (the BL-16548 redesign).

Changes

  • Team-collection icon no longer hidden by the "…" menu. The team icon sat at the top-right of the title row — the same corner where the hover "…" menu button appears — so the button covered it. Moved the icon down into the left of the metadata row (beside the book count).
  • "…" menu shows the collection folder, not the .bloomCollection file. Backend now returns a folderPath field; the card displays that (falling back to deriving it from path for stories/tests).
  • Footer contrast. Darkened the footer band (#fafafa#f0f0f0, border #eee#e0e0e0) so it's clearly distinguishable from the white dialog body.

Not included (deliberately)

Heather also reported that only 10 collections show at a time. That's the maxMruItems = 10 cap in CollectionChooserApi, but it's an intentional "most recently used" limit and changing it is a design decision (and has an eager-per-card book-count perf cost), so it's left out of this PR.

Ref: https://issues.bloomlibrary.org/youtrack/issue/BL-16548

Devin review


This change is Reviewable

hatton and others added 2 commits July 16, 2026 11:07
…ter (BL-16548)

Follow-up UI tweaks from QA on the Open / Create Collections dialog:

- The team-collection icon shared the top-right corner with the hover "..."
  menu button, so the button covered the icon. Move the icon down into the
  left of the metadata row (beside the book count), leaving the corner to the
  "..." button.

- The "..." menu showed the full .bloomCollection file path; show just the
  containing folder instead. The backend now returns a folderPath field; the
  card displays it (falling back to deriving it from path for stories/tests).

- Darken the footer band (#fafafa -> #f0f0f0, border #eee -> #e0e0e0) so it is
  clearly distinguishable from the white dialog body.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Three focused follow-up UI fixes for the Open/Create Collections dialog after a QA pass. All changes are additive and backward-compatible — the existing handleOpenInFileExplorer still posts props.path (the .bloomCollection file), which the backend HandleOpenCollectionFolderInExplorer already handles by detecting whether the path is a file or directory.

  • TeamCollectionIcon relocation: removed from the title row (where it competed with the "…" button) and placed as the first item in the metadata row with flex: none, consistent with the existing gap: 10px and align-items: center on metadataRowStyle.
  • Folder path in menu: folderPath was already computed in MakeCollectionInfoObject — the change simply includes it in the JSON response; the frontend falls back gracefully via a regex that correctly handles both Unix and Windows path separators.
  • Footer contrast: two CSS values bumped from near-white to a slightly darker shade.

Important Files Changed

Filename Overview
src/BloomBrowserUI/collection/CollectionCard.tsx Moves TeamCollectionIcon from the title row into the metadata row, adds folderPath derivation and display in the "…" menu. Logic is sound; fallback regex handles both Unix and Windows separators.
src/BloomBrowserUI/collection/CollectionChooserDialog.tsx Two-line CSS tweak to darken footer background and border — straightforward and safe.
src/BloomExe/web/controllers/CollectionChooserApi.cs Exposes the already-computed folderPath variable in the JSON response — a one-line addition with no behavioral side effects.

Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mas..." | Re-trigger Greptile

@hatton

hatton commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

[Claude Opus 4.8] Consulted Devin on 2026-07-16 17:12 UTC up to commit 368a9740c8558d0fb535a0d63c4e941a404e3cbd. Result: 0 Bugs, 0 Investigate flags (2 Informational observations only — not actionable). CI/other bots: see checks. No findings to mirror.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant