Skip to content

Tweak copyright & license dialog styling (BL-16552) #8065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hatton wants to merge 4 commits into
base: master
Choose a base branch
from
+9 −3
Draft

Tweak copyright & license dialog styling (BL-16552) #8065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76fac17
Tweak copyright & license dialog styling (BL-16552)
hatton Jul 15, 2026
6e9396f
Merge remote-tracking branch 'origin/master' into BL-16552-Tweak-copy…
hatton Jul 15, 2026
02930c8
Remove the dark box behind the CC license badge (BL-16552)
hatton Jul 15, 2026
0628916
Merge remote-tracking branch 'origin/master' into BL-16552-Tweak-copy…
hatton Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/BloomBrowserUI/bookEdit/copyrightAndLicense/CopyrightAndLicenseDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,8 @@ export const CopyrightAndLicenseDialog: React.FunctionComponent<{
css={css`
padding-bottom: 0;
margin-bottom: 0;
font-size: 20px;
font-weight: 500;
`}
/>
{
Expand Down Expand Up @@ -271,7 +273,11 @@ export const CopyrightAndLicenseDialog: React.FunctionComponent<{
css={css`
.react-tabs__tab-panel--selected > div {
padding: 0; // This cancels a rule in BloomUI.less which is too global
padding-top: 20px;
padding-top: 24px;
}
.react-tabs__tab {
font-size: 14px;
letter-spacing: 0.05em;
}
`}
>
Expand Down
4 changes: 2 additions & 2 deletions src/BloomBrowserUI/bookEdit/copyrightAndLicense/CopyrightPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export const CopyrightPanel: React.FunctionComponent<{
error={!isYearValid}
css={css`
width: 150px; // Enough for slightly longer translations of the label; English only needs 100px
margin-bottom: 20px !important;
margin-bottom: 22px !important;

// Hide the up/down control
input {
Expand All @@ -167,7 +167,7 @@ export const CopyrightPanel: React.FunctionComponent<{
required={true}
error={!isHolderValid}
css={css`
margin-bottom: 11px !important;
margin-bottom: 22px !important;

@hatton hatton Jul 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Devin] Investigate: Doubled bottom margin on Copyright Holder field within a fixed-height dialog

Devin flagged that the Copyright Holder field's bottom margin went from 11px to 22px (and the Year field similarly) while this dialog has a fixed height (575px). Combined with the tab-panel top-padding increase (20px → 24px), that's roughly 15px more vertical space used. Devin rates overflow as unlikely given the available headroom, but worth an eyeball — especially in the derivative-book scenario, where the Copyright panel also shows the "Not a translation" checkbox and the original-copyright text below these fields. Please confirm nothing gets clipped there.

Assessment (Claude Opus 4.8): low risk — the dialog has headroom and this is exactly what the visual pass will catch — but a fair thing to verify since it's a fixed-height dialog. Leaving this thread open for the visual check rather than resolving it.

`}
/>
{/* keeping this for now in case things change, but the restrictions on what can
Expand Down