Tweak copyright & license dialog styling (BL-16552)#8065
Conversation
Dialog polish in the Copyright & License dialog: - Larger, medium-weight dialog title; more tab-panel top padding; and slightly larger, letter-spaced tab labels. - Consistent bottom spacing for the year and copyright-holder fields in the Copyright panel. - Wrap the Creative Commons license badge image in a dark, rounded block so it reads as a badge against the dialog background. Also raise the Vite health-check timeouts in the dev launcher (go.mjs): the overall settle timeout 15s -> 30s and the per-probe request timeout from a hardcoded 500ms to a named 3s constant, so a slow-but-listening Vite cold start is no longer spuriously aborted. A genuinely dead server still fails fast via ECONNREFUSED. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…right-license-dialog
|
| Filename | Overview |
|---|---|
| src/BloomBrowserUI/bookEdit/copyrightAndLicense/CopyrightAndLicenseDialog.tsx | Adds font-size/font-weight to DialogTitle via css prop (will be silently dropped — DialogTitle doesn't forward className and its internal * rule overrides descendants), increases tab-panel padding from 20px to 24px, and adds font-size/letter-spacing to tab labels via scoped class selectors. |
| src/BloomBrowserUI/bookEdit/copyrightAndLicense/CopyrightPanel.tsx | Equalizes bottom-margin on the year field (20→22px) and copyright-holder field (11→22px) for visual consistency; straightforward cosmetic change. |
Comments Outside Diff (1)
-
src/BloomBrowserUI/bookEdit/copyrightAndLicense/CopyrightAndLicenseDialog.tsx, line 220-228 (link)font-size/font-weightstyles onDialogTitlewill be silently droppedDialogTitle(inBloomDialog.tsx) does not accept aclassNameprop and does not spread...propsto its rootdiv. Emotion converts acssprop on a custom component into a generatedclassNameand passes it to the component; if the component ignoresclassName, the styles never reach any DOM element. Even if they did reach the outerdiv, the component's internal* { font-size: 16px; font-weight: bold; }rule explicitly sets these on all descendants (including theh1that rendersprops.title), so theh1will always be16px boldregardless. The stated goal of "Larger, medium-weight dialog title" won't be achieved by this approach. To make the title larger/lighter,DialogTitlewould need to accept a dedicated prop (e.g.titleStyle) or accept and forwardclassName, and its internal*wildcard rule would need to be narrowed.
Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'origin/mas..." | Re-trigger Greptile
|
[Claude Opus 4.8] Consulted Devin on 2026-07-15 up to commit |
The earlier styling pass wrapped the Creative Commons badge image in a dark (#555) rounded block. That reads as an unwanted gray box around the icon, so revert LicenseBadge back to the plain right-aligned 100px image as it was before. The rest of the dialog typography/spacing tweaks stay.
…right-license-dialog
| error={!isHolderValid} | ||
| css={css` | ||
| margin-bottom: 11px !important; | ||
| margin-bottom: 22px !important; |
There was a problem hiding this comment.
[Devin] Investigate: Doubled bottom margin on Copyright Holder field within a fixed-height dialog
Devin flagged that the Copyright Holder field's bottom margin went from 11px to 22px (and the Year field similarly) while this dialog has a fixed height (575px). Combined with the tab-panel top-padding increase (20px → 24px), that's roughly 15px more vertical space used. Devin rates overflow as unlikely given the available headroom, but worth an eyeball — especially in the derivative-book scenario, where the Copyright panel also shows the "Not a translation" checkbox and the original-copyright text below these fields. Please confirm nothing gets clipped there.
Assessment (Claude Opus 4.8): low risk — the dialog has headroom and this is exactly what the visual pass will catch — but a fair thing to verify since it's a fixed-height dialog. Leaving this thread open for the visual check rather than resolving it.
|
[Claude Opus 4.8] Consulted Devin on 2026-07-15 up to commit |
Polish for the Copyright & License dialog (BL-16552):
Ref: https://issues.bloomlibrary.org/youtrack/issue/BL-16552
🤖 Generated with Claude Code
This change is