Merged
Conversation
|
|
||
| before do | ||
| allow(Date).to receive(:today).and_return(today) | ||
| allow(Config).to receive(:skip_fte_check?).and_return(false) |
There was a problem hiding this comment.
I see you configured this but do you have a test to call the method with a true return and one for a false return?
Contributor
Author
There was a problem hiding this comment.
Good call. The branch is covered..., but I don't have an explicit test for skip_fte_check (there are just tests that touch both scenarios), but probably good to have an explicit test for that purpose...I'll add that in!
Contributor
Author
There was a problem hiding this comment.
Added test for FTE function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AP-559 - Update the 0FTE check to allow for some exceptions
Following job codes should be included even if the job has zero percent of full time employment: