Restore azuredeploy.json for key-vault-create#14742
Restore azuredeploy.json for key-vault-create#14742msmbaldwin wants to merge 1 commit intoAzure:masterfrom
Conversation
Re-adds azuredeploy.json (compiled from main.bicep) which was incorrectly removed during the recent RBAC modernization PR. The 'Deploy to Azure' button in README.md links to this file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@mumian - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.] |
|
@alex-frankel — quick explanation and ask: When the four KV RBAC PRs (#14704, #14705, #14706, #14707) were prepared, This PR (and its three siblings #14739, #14740, #14742) just adds the missing MAC is green on all four. The red "Validate" check is the same |
@msmbaldwin did you get a chance to review the error from the validation : ❌ ERROR – Template file(s) changed but metadata.json was NOT updated. The following template files were modified: metadata.json must include a 'testResult' section with deployment This check exists because the second validation workflow To fix: deploy your updated template(s) and add the deployment The pipeline will internally generate the json file from the bicep for verification but will not be added to the change list. If this is breaking the deploy to azure button that is definitely something that needs to be looked at |
|
Thanks for the explanation — that clarifies things, and I agree the broken Deploy-to-Azure button is the deeper concern. To confirm the path forward on these four PRs: do you want me to deploy each of the four templates manually and populate Happy to do whichever you prefer. Just want to make sure the workflow expectations are clear for next time too — historically the MAC schema rejected |
Re-adds
azuredeploy.jsonfor thekey-vault-createsample.Why?
azuredeploy.jsonwas removed in #14704 under the (incorrect) assumption that CI would regenerate the compiled JSON frommain.bicepautomatically. AQT doesn't do that — both files are expected to be committed by the contributor, and the "Deploy to Azure" / "Visualize" buttons inREADME.mdlink directly toazuredeploy.json.How was it generated?
az bicep buildagainst themain.bicepalready on master. No template logic changes.