Skip to content

Restore azuredeploy.json for key-vault-create#14742

Open
msmbaldwin wants to merge 1 commit intoAzure:masterfrom
msmbaldwin:akv-restore-key-vault-create-json
Open

Restore azuredeploy.json for key-vault-create#14742
msmbaldwin wants to merge 1 commit intoAzure:masterfrom
msmbaldwin:akv-restore-key-vault-create-json

Conversation

@msmbaldwin
Copy link
Copy Markdown
Contributor

Re-adds azuredeploy.json for the key-vault-create sample.

Why?

azuredeploy.json was removed in #14704 under the (incorrect) assumption that CI would regenerate the compiled JSON from main.bicep automatically. AQT doesn't do that — both files are expected to be committed by the contributor, and the "Deploy to Azure" / "Visualize" buttons in README.md link directly to azuredeploy.json.

How was it generated?

az bicep build against the main.bicep already on master. No template logic changes.

Re-adds azuredeploy.json (compiled from main.bicep) which was incorrectly removed during the recent RBAC modernization PR. The 'Deploy to Azure' button in README.md links to this file.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-quickstarts azure-quickstarts added the remove azuredeploy.json bicep sample, remove json from PR label May 7, 2026
@azure-quickstarts
Copy link
Copy Markdown
Collaborator

@mumian - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

@msmbaldwin
Copy link
Copy Markdown
Contributor Author

@alex-frankel — quick explanation and ask:

When the four KV RBAC PRs (#14704, #14705, #14706, #14707) were prepared, azuredeploy.json was deleted under the (wrong) assumption that CI would regenerate it from main.bicep. It doesn't, and the "Deploy to Azure" buttons in each README.md link directly to azuredeploy.json — so the merged samples are currently broken.

This PR (and its three siblings #14739, #14740, #14742) just adds the missing azuredeploy.json, generated via az bicep build from the main.bicep already on master. No template logic changes.

MAC is green on all four. The red "Validate" check is the same testResult-required-vs-MAC-schema-rejects-it conflict you merged through on the original PRs. Could you take a look when you have a minute? Thanks!

@ouldsid
Copy link
Copy Markdown
Member

ouldsid commented May 7, 2026

@alex-frankel — quick explanation and ask:

When the four KV RBAC PRs (#14704, #14705, #14706, #14707) were prepared, azuredeploy.json was deleted under the (wrong) assumption that CI would regenerate it from main.bicep. It doesn't, and the "Deploy to Azure" buttons in each README.md link directly to azuredeploy.json — so the merged samples are currently broken.

This PR (and its three siblings #14739, #14740, #14742) just adds the missing azuredeploy.json, generated via az bicep build from the main.bicep already on master. No template logic changes.

MAC is green on all four. The red "Validate" check is the same testResult-required-vs-MAC-schema-rejects-it conflict you merged through on the original PRs. Could you take a look when you have a minute? Thanks!

@msmbaldwin did you get a chance to review the error from the validation : ❌ ERROR – Template file(s) changed but metadata.json was NOT updated.

The following template files were modified:
- quickstarts/microsoft.keyvault/key-vault-create/azuredeploy.json

metadata.json must include a 'testResult' section with deployment
results for every deployment template in the sample.
Any change to a .bicep or .json template requires re-running the
deployment and updating testResult in metadata.json accordingly.

This check exists because the second validation workflow
(Validate ARM Deployments via ADX) will fail if testResult
does not match the current template content.

To fix: deploy your updated template(s) and add the deployment
results to the 'testResult.deployments' array in metadata.json.

The pipeline will internally generate the json file from the bicep for verification but will not be added to the change list. If this is breaking the deploy to azure button that is definitely something that needs to be looked at

@msmbaldwin
Copy link
Copy Markdown
Contributor Author

Thanks for the explanation — that clarifies things, and I agree the broken Deploy-to-Azure button is the deeper concern.

To confirm the path forward on these four PRs: do you want me to deploy each of the four templates manually and populate testResult.deployments with the resulting correlationId / deploymentName? Or, since AzQuickStarts-MAC already deployed them successfully (build #187138 for this PR), is there a way to reuse the IDs from that internal run?

Happy to do whichever you prefer. Just want to make sure the workflow expectations are clear for next time too — historically the MAC schema rejected testResult, which is why it isn't on these samples (or the originals: #14704, #14705, #14706, #14707).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

remove azuredeploy.json bicep sample, remove json from PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants